Date: Mon, 30 Nov 2020 11:52:32 -0700 From: Warner Losh <imp@bsdimp.com> To: Mathieu Arnold <mat@freebsd.org> Cc: Rene Ladan <rene@freebsd.org>, Chris Rees <crees@freebsd.org>, Adam Weinberger <adamw@adamw.org>, git@freebsd.org, "portmgr@FreeBSD.org" <portmgr@freebsd.org> Subject: Re: converting rmport to git Message-ID: <CANCZdfrhP5pUpsEzHB6DzhyVRnBpefsFQgXyR9fAm7of%2BSw-Qg@mail.gmail.com> In-Reply-To: <20201130115743.elfr6y2anpuoh5gy@aching.in.mat.cc> References: <20201129164707.GA31739@freefall.freebsd.org> <CAP7rwchHsz3x4v%2BWmxEqTyXOvJx6fUbRuKnirBPEPVzz7gMw0A@mail.gmail.com> <14871125-A032-4980-8DB1-0210E34D5A11@FreeBSD.org> <20201130105337.GA42359@freefall.freebsd.org> <20201130115743.elfr6y2anpuoh5gy@aching.in.mat.cc>
index | next in thread | previous in thread | raw e-mail
On Mon, Nov 30, 2020 at 4:57 AM Mathieu Arnold <mat@freebsd.org> wrote: > On Mon, Nov 30, 2020 at 10:53:37AM +0000, Rene Ladan wrote: > > OK, I'll rewrite the script to use the branch workflow. This does assume > > having an existing clone of the git repository present, but I guess that > > is a safe assumption if you are a ports committer :) > > You really should not to worry about branches, the script could emit a > warning if it runs on the default branch, which will be something like > "main" but the script should not worry about all that, it should just > assume it has the checkout of the thing you need to remove ports from, > let the user worry about working on some branch or not. > A clean tree is the only real requirement, and all you need to check for / assume. However, it would be nice to allow for the steps to create a branch and/or worktree, if desired. There are times you'd want to run this in a mode that just does it and then you push. And there's times you need to run more extensive testing / regression. Automating the branching dance would allow for that. Making it optional would address the likely more typical case of 'I just want to remove this port'. Warnerhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrhP5pUpsEzHB6DzhyVRnBpefsFQgXyR9fAm7of%2BSw-Qg>