Date: Fri, 31 Jul 2026 11:36:48 +0000 From: Kevin Bowling <kbowling@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 8d1d32942b81 - main - ixgbe: check negotiated API for VF queue query Message-ID: <6a6c88d0.3efea.13eadd33@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=8d1d32942b810d613be45ea78939872711803c3b commit 8d1d32942b810d613be45ea78939872711803c3b Author: Kevin Bowling <kbowling@FreeBSD.org> AuthorDate: 2026-07-28 11:20:08 +0000 Commit: Kevin Bowling <kbowling@FreeBSD.org> CommitDate: 2026-07-31 11:36:16 +0000 ixgbe: check negotiated API for VF queue query The GET_QUEUES handler switches on msg[0], which contains the mailbox command rather than the negotiated API version. It therefore cannot reject API 1.0 or an unnegotiated VF as intended. Switch on the API version stored for the VF. MFC after: 1 week --- sys/dev/ixgbe/if_sriov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/if_sriov.c b/sys/dev/ixgbe/if_sriov.c index 8230464bd9bc..c822303a4067 100644 --- a/sys/dev/ixgbe/if_sriov.c +++ b/sys/dev/ixgbe/if_sriov.c @@ -553,7 +553,7 @@ ixgbe_vf_get_queues(struct ixgbe_softc *sc, struct ixgbe_vf *vf, hw = &sc->hw; /* GET_QUEUES is not supported on pre-1.1 APIs. */ - switch (msg[0]) { + switch (vf->api_ver) { case IXGBE_API_VER_1_0: case IXGBE_API_VER_UNKNOWN: ixgbe_send_vf_failure(sc, vf, msg[0]);home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a6c88d0.3efea.13eadd33>