Date: Fri, 3 Aug 2012 10:22:54 -0700 From: Jim Harris <jimharris@freebsd.org> To: Marcelo Gondim <gondim@bsdinfo.com.br> Cc: freebsd-stable@freebsd.org Subject: Re: geom_virstor with kernel panic in FreeBSD 9.x Message-ID: <CAJP=Hc9_Gqoq85WMe1wrT4xsZ=eHRO%2BVEi4NdOt64aEdjTr8dw@mail.gmail.com> In-Reply-To: <501C0485.8070002@bsdinfo.com.br> References: <1977769407.20120322151934@tkachuk.name> <4F6B4030.5090907@FreeBSD.org> <4F6B4631.8020006@gmail.com> <4F6B4B93.7020309@FreeBSD.org> <4F6B4FAB.1020202@gmail.com> <1332434072.8403.79.camel@revolution.hippie.lan> <E1SGoVX-000EYm-90@kabab.cs.huji.ac.il> <501B8004.1000503@ateamsystems.com> <501BBEBB.5010106@bsdinfo.com.br> <CAJP=Hc-r0zE6tDPQozEbmoSqD%2BHnxzqRzG=mummE7jWzQOsZEQ@mail.gmail.com> <501C0485.8070002@bsdinfo.com.br>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Fri, Aug 3, 2012 at 10:04 AM, Marcelo Gondim <gondim@bsdinfo.com.br> wrote:
> Hi Jim,
>
> When I applied the patch gave this error:
>
> # patch < /root/patch.diff
> Hmm... Looks like a unified diff to me...
> The text leading up to this was:
> --------------------------
>
> |--- sys/geom/virstor/g_virstor.c (revision 238909)
> |+++ sys/geom/virstor/g_virstor.c (working copy)
> --------------------------
> Patching file sys/geom/virstor/g_virstor.c using Plan A...
> Hunk #1 failed at 235.
> 1 out of 1 hunks failed--saving rejects to sys/geom/virstor/g_virstor.c.rej
> done
>
>
>
Strange. It applies with no issues on my checkout.
Let's try an attachment instead. If this doesn't work, could you
kindly apply the patch by hand?
Thanks,
-Jim
[-- Attachment #2 --]
Index: sys/geom/virstor/g_virstor.c
===================================================================
--- sys/geom/virstor/g_virstor.c (revision 239019)
+++ sys/geom/virstor/g_virstor.c (working copy)
@@ -234,6 +234,12 @@
return;
}
sc = virstor_find_geom(cp, name);
+ if (sc == NULL) {
+ gctl_error(req, "Don't know anything about '%s'", name);
+ g_topology_unlock();
+ return;
+ }
+
LOG_MSG(LVL_INFO, "Stopping %s by the userland command",
sc->geom->name);
update_metadata(sc);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJP=Hc9_Gqoq85WMe1wrT4xsZ=eHRO%2BVEi4NdOt64aEdjTr8dw>