Date: Thu, 7 Apr 2011 13:53:16 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Alexander Best <arundel@freebsd.org> Cc: freebsd-current@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: [RFC] adding -Wmissing-include-dirs to CWARNFLAGS Message-ID: <BANLkTinWdMf3jXa=zk4Yi08oW4Du4zzeFg@mail.gmail.com> In-Reply-To: <20110407185510.GA94830@freebsd.org> References: <20110407185510.GA94830@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 7, 2011 at 11:55 AM, Alexander Best <arundel@freebsd.org> wrote:
> hi there,
>
> i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this will let
> tinderbox fail, if any new kernel code was committed with (a) broken include
> dir(s).
>
> i ran a test via
>
> make toolchains
> make MAKE_JUST_KERNELS=yes tinderbox
>
> and nothing seemed to go wrong with the extra warning enabled. i even found a
> missing include dir, which should be fixed by the attached patch.
>
> opinions?
>
> so far i've only tested this with gcc. i think someone on #freebsd-clang told
> me that -Wmissing-include-dirs is a noop for clang (for whatever reasons).
make -f /etc/src.conf -VMODULES_OVERRIDE and make -f /etc/src.conf
-VMODULES_OVERRIDE say... (tinderbox should also really ignore these
files, but it doesn't currently)?
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTinWdMf3jXa=zk4Yi08oW4Du4zzeFg>