Date: Thu, 02 Feb 2017 20:51:33 -0400 From: Joseph Mingrone <jrm@FreeBSD.org> To: ashish@FreeBSD.org (Ashish SHUKLA) Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r433143 - head/editors/emacs-devel Message-ID: <861svg5c6i.fsf@phe.ftfl.ca> In-Reply-To: <86y3xot8mo.fsf@FreeBSD.org> (Ashish SHUKLA's message of "Fri, 03 Feb 2017 06:04:23 %2B0530") References: <201702021252.v12CqTos081552@repo.freebsd.org> <86y3xot8mo.fsf@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain ashish@FreeBSD.org (Ashish SHUKLA) writes: > On Thu, 2 Feb 2017 12:52:29 +0000 (UTC), Joseph Mingrone <jrm@FreeBSD.org> said: > | Author: jrm > | Date: Thu Feb 2 12:52:29 2017 > | New Revision: 433143 > | URL: https://svnweb.freebsd.org/changeset/ports/433143 > | Log: > | editors/emacs-devel: Update to latest commit on master branch > | Approved by: ashish (maintainer, implicit), swills (mentor, implicit) > Hi Joseph, > Thanks for the update, although I didn't approve this diff. > The implicit approval you sought[1] was for PORTREVISION bump, and this commit > is not that. > References: > [1] https://reviews.freebsd.org/D9287#192339 > Thanks! Hello Ashish, My apologies! This indeed wasn't what we had agreed upon. I somehow had it in my mind that the implicit approval was for updating to a newer upstream commit. Hopefully this will teach me not to do such things in a rush with many other things going on at the same time. This commit was in the spirit on what I had in mind. That is, get newer code out regularly in the -devel port, so users can test early and often. Would such a commit, that only modifies the GH_TAGNAME, EMACS_REV, and the distfile also be acceptable for implicit approval? Again, sorry for breaking our agreement. It was due to careless and not intentional. Joseph --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJYk9QVXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1NUIwOTNBNzI2QzM4ODU1NzEyMkJBRDUz NkE0MEM4M0IwRDZFRjlFAAoJEDakDIOw1u+e9c0P/AhjGgVAyx8kczjJhGDl8wSr VJ95zpuYfAxlvix55yWHm93S2SgSSZX7ICX6yDvp33tW/fVl5/nSMWBTT392lfT0 encFo8ZbkmKF6iCOKjz1kglRLZ25HdqIZ03M86QWmGwL4Kw+xTXbEXMlAwi1wTCx 8DIZO5bzRmJiKpLhsEquUuF90q2YFSsIBB1F1ot54JrCdAZG42rsQEqGsHU2Qblw kITyc6Oopk2KWR1h1zXFS6TPMJ4K7qX1Peg7VzlmxV8UsW1MLkz4YhV1oIs8QBDq L0IfQwxZqaDNmL2XHmncrlD9cD9h0+p9051wjKX9Tpra1mOBqQXXxcY51coUemKG 0w68jhQwN7xTDtB0SjMIASOvPTBhu3nCDYRH1H5Jrad0UdQl1VWdhT5ygReQWgCn gvytLwh5AxR5adIytwV4brEHKM82ywwRHySQSHEDcK2SzUP/kHFoEUtKN4RCh12S gudjW+SObCEXXT5LzApbDDHSu898HyDrCbwtch+eQzhgkneioJC4yV07A5/e91+5 cMIvV01B781JoJ/MDV5SnRYfp5NQpn6v4B/aliLFLOpUd2H2YsFjQjx/wZ32suKg tLkmuWzojwQfaJccE0cCPw6dvGqWI9IIj8nFxESti2usSEDaNPNnOxLCZG5ksZnA fknXSBSBTZZHti8d9zmL =IhHf -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?861svg5c6i.fsf>