Date: Tue, 30 Mar 2010 18:26:36 +0300 From: Alexander Motin <mav@FreeBSD.org> To: Bruce Cran <brucec@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r205119 - head/contrib/top Message-ID: <4BB2182C.4080203@FreeBSD.org> In-Reply-To: <201003131117.o2DBHek2003410@svn.freebsd.org> References: <201003131117.o2DBHek2003410@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Cran wrote: > Author: brucec > Date: Sat Mar 13 11:17:39 2010 > New Revision: 205119 > URL: http://svn.freebsd.org/changeset/base/205119 > > Log: > Change the 'amt' parameter in format_k2 from int to unsigned long long > to match the values passed in and prevent the SIZE field being corrupted > when more than 2TB is allocated. This change seems broke top on ARM, as declaration in util.h doesn't specifies argument type, and caller assumes int there. To make it work correctly, second part should be done: --- top.prev/utils.h 2009-10-14 15:23:42.000000000 +0300 +++ top/utils.h 2010-03-30 18:14:11.000000000 +0300 @@ -21,4 +21,4 @@ long percentages(); char *errmsg(); char *format_time(); char *format_k(); -char *format_k2(); +char *format_k2(unsigned long long); -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BB2182C.4080203>