Date: Sun, 15 Dec 2013 22:48:46 -0500 (EST) From: Benjamin Kaduk <bjk@freebsd.org> To: Glen Barber <gjb@freebsd.org> Cc: Benjamin Kaduk <bjk@freebsd.org>, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org, svn-src-stable@freebsd.org Subject: Re: svn commit: r259449 - in stable/8: . crypto/heimdal/lib/gssapi/krb5 sys/sys Message-ID: <alpine.GSO.1.10.1312152248100.27579@multics.mit.edu> In-Reply-To: <20131216034043.GK1446@glenbarber.us> References: <201312160230.rBG2UvH5008664@svn.freebsd.org> <20131216034043.GK1446@glenbarber.us>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 15 Dec 2013, Glen Barber wrote: > On Mon, Dec 16, 2013 at 02:30:57AM +0000, Benjamin Kaduk wrote: >> Author: bjk (doc committer) >> Date: Mon Dec 16 02:30:56 2013 >> New Revision: 259449 >> URL: http://svnweb.freebsd.org/changeset/base/259449 >> >> Log: >> MFC r259286,259424,259425: >> Apply patch from upstream Heimdal for encoding fix >> >> RFC 4402 specifies the implementation of the gss_pseudo_random() >> function for the krb5 mechanism (and the C bindings therein). >> The implementation uses a PRF+ function that concatenates the output >> of individual krb5 pseudo-random operations produced with a counter >> and seed. The original implementation of this function in Heimdal >> incorrectly encoded the counter as a little-endian integer, but the >> RFC specifies the counter encoding as big-endian. The implementation >> initializes the counter to zero, so the first block of output (16 octets, >> for the modern AES enctypes 17 and 18) is unchanged. (RFC 4402 specifies >> that the counter should begin at 1, but both existing implementations >> begin with zero and it looks like the standard will be re-issued, with >> test vectors, to begin at zero.) >> > > This breaks stable/8 build. Looking... -Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.GSO.1.10.1312152248100.27579>