Date: Mon, 10 Jan 2011 16:53:26 -0500 (EST) From: Rick Macklem <rmacklem@uoguelph.ca> To: john.gemignani@isilon.com Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217242 - head/sys/rpc Message-ID: <569448948.110324.1294696406344.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <201101102135.p0ALZAhV095080@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----- Original Message ----- > Author: rmacklem > Date: Mon Jan 10 21:35:10 2011 > New Revision: 217242 > URL: http://svn.freebsd.org/changeset/base/217242 > > Log: > Fix a bug in the client side krpc where it was, sometimes > erroneously, assumed that 4 bytes of data were in the first > mbuf of a list by replacing the bcopy() with m_copydata(). > Also, replace the uses of m_pullup(), which can fail for > reasons other than not enough data, with m_copydata(). > For the cases where it isn't known that there is enough > data in the mbuf list, check first via m_len and m_length(). > This is believed to fix a problem reported by dpd at dpdtech.com > and george+freebsd at m5p.com. > > Reviewed by: jhb > MFC after: 8 days > Oops, I forgot to mention that john.gemignani at isilon.com spotted and reported this bug via email. Thanks go to him for that. rick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?569448948.110324.1294696406344.JavaMail.root>