Date: Fri, 17 Aug 2018 23:24:09 -0700 From: Gordon Tetlow <gordon@tetlows.org> To: Conrad Meyer <cem@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337936 - in head/sys/contrib/libsodium: . builds builds/msvc builds/msvc/build builds/msvc/properties builds/msvc/vs2010 builds/msvc/vs2010/libsodium builds/msvc/vs2012 builds/msvc/vs2... Message-ID: <20180818062409.GA6651@gmail.com> In-Reply-To: <201808170023.w7H0Np0H027296@repo.freebsd.org> References: <201808170023.w7H0Np0H027296@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 17, 2018 at 12:23:51AM +0000, Conrad Meyer wrote: > Author: cem > Date: Fri Aug 17 00:23:50 2018 > New Revision: 337936 > URL: https://svnweb.freebsd.org/changeset/base/337936 >=20 > Log: > Bring in libsodium to sys/contrib > =20 > Bring in https://github.com/jedisct1/libsodium at > 461ac93b260b91db8ad957f5a576860e3e9c88a1 (August 7, 2018), unmodified. > =20 > libsodium is derived from Daniel J. Bernstein et al.'s 2011 NaCl > ("Networking and Cryptography Library," pronounced "salt") software lib= rary. > At the risk of oversimplifying, libsodium primarily exists to make it e= asier > to use NaCl. NaCl and libsodium provide high quality implementations o= f a > number of useful cryptographic concepts (as well as the underlying > primitics) seeing some adoption in newer network protocols. > =20 > I considered but dismissed cleaning up the directory hierarchy and > discarding artifacts of other build systems in favor of remaining close= to > upstream (and easing future updates). > =20 > Nothing is integrated into the build system yet, so in that sense, no > functional change. Hi! so@ here. Please don't integrate an additional crypto library without consultation from secteam. Bringing in a different crypto implementation has very serious downstream costs. Additionally, I don't see any discussion on current, hackers, arch, or security with a plan for why this is coming into the tree. That said, I've been on vacation the last two weeks, so if I missed something, please feel free to point it out to me. Thanks, Gordon --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEuyjUCzYO7pNq7RVv5fe8y6O93fgFAlt3u4BfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEJC MjhENDBCMzYwRUVFOTM2QUVEMTU2RkU1RjdCQ0NCQTNCRERERjgACgkQ5fe8y6O9 3fg0Qwf+NIuOpRcrCy9oDo5rzsqOOLUAf79uIWZTRWkwQI0OTkpwRbxsnkH7zubu Lfaq/76zIVYgmlC7swg3P3beEbFvLYNAMs9GZtiyfwNT+N8YNPTz5HFvWhp1pfOw QfWI0OIqetApLBinoMdVRd5YDKJb5np/eTJaIejQ4QXUZeqiHeDRp+yykRxyT6IY DbVDQDtEUj9w64HH2ijKCxzT/jYjEQ+Gd8vCEMhKWO1FT+5keomyquWgSw1AVKXF QBg4G4ANd59EF++y7Ms5iCLz+0nAIUEaZZrr2xM4iVMjuIsuiaBt+/rLzjOfhnON 54rpcR+XTZx9hMzXumcSnz1QyWvtyQ== =v7s7 -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180818062409.GA6651>