Date: Sat, 2 Feb 2008 20:09:33 +0100 From: Olivier Houchard <mlfbsd@ci0.org> To: Soeren Straarup <xride@x12.dk> Cc: arm@freebsd.org Subject: Re: about src/lib/libkse/arch/arm/include/pthread_md.h Message-ID: <20080202190933.GA18088@ci0.org> In-Reply-To: <20080202185449.6b9068a2@x12.dk> References: <20080202090238.289eeb66@x12.dk> <20080202183138.GA17602@ci0.org> <20080202185449.6b9068a2@x12.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 02, 2008 at 06:54:49PM +0100, Soeren Straarup wrote:
> On Sat, 2 Feb 2008 19:31:38 +0100
> Olivier Houchard <mlfbsd@ci0.org> wrote:
>
> > Hi Soeren,
> >
> > On Sat, Feb 02, 2008 at 09:02:38AM +0100, Soeren Straarup wrote:
> > > Hi,
> > >
> > > Index: pthread_md.h
> > > ===================================================================
> > > RCS file: /home/ncvs/src/lib/libkse/arch/arm/include/pthread_md.h,v
> > > retrieving revision 1.9
> > > diff -u -r1.9 pthread_md.h
> > > --- pthread_md.h 9 Oct 2007 13:42:23 -0000 1.9
> > > +++ pthread_md.h 1 Feb 2008 22:48:50 -0000
> > > @@ -240,7 +240,7 @@
> > > tcb->tcb_tmbx.tm_lwp = kcb->kcb_kmbx.km_lwp;
> > > if (setmbox)
> > > _thr_setcontext(mc,
> > > (intptr_t)&tcb->tcb_tmbx,
> > > - (intptr_t
> > > *)&kcb->kcb_kmbx.km_curthread);
> > > + (intptr_t
> > > *)kcb->kcb_kmbx.km_curthread); else
> > > _thr_setcontext(mc, 0, NULL);
> > > } else {
> > >
> > >
> > > Is that change correct?
> > >
> >
> > If I'm nor wrong, the original code is right, and that's what the
> > other platforms seem to do so. Why do you think it should be changed ?
> >
>
> Due to that if gcc is run with warnings set as errors it breaks.
>
We probably should do what other platforms do, and cast it to (void *)
before (intptr_t *).
Wanna commit it, or shall I ?
Olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080202190933.GA18088>