Date: Fri, 23 Feb 2018 14:39:39 -0500 From: Charles Sprickman <spork@bway.net> To: Mathieu Arnold <mat@FreeBSD.org> Cc: apache@FreeBSD.org Subject: Re: FreeBSD Port: www/mod_cband Message-ID: <3932758D-E9C3-4B02-93F3-8B90C0E7B4FE@bway.net> In-Reply-To: <20180223144954.bvr3r5viqtvg3cfi@ogg.in.absolight.net> References: <760D90A5-E9AB-41D4-9E63-E32052DAAAB7@bway.net> <20180223144954.bvr3r5viqtvg3cfi@ogg.in.absolight.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Feb 23, 2018, at 9:49 AM, Mathieu Arnold <mat@FreeBSD.org> wrote: > > On Wed, Feb 21, 2018 at 02:42:50AM -0500, Charles Sprickman via freebsd-apache wrote: >> Hi, >> >> I’m testing out one of the patches floating around to make mod_cband work on apache 2.4.x, is there any interest in including this small patch (and one Makefile change) so that mod_cband can be used with a current apache? After lots of looking, I’m not seeing anything else that really compares to mod_cband, especially for web hosting where one needs to enforce a quota on bytes transferred over a period of time (week, month). >> >> Makefile change is just "USE_APACHE= 22” to "USE_APACHE= 22+”. >> >> The other changes are pretty small and are attached - dump them in the port’s “files” directory and it should build. The compiler warnings are the same as those generated by the current port (strncmp suggestions, unsigned int comparison warning). >> >> I’m running this now on a 10.4 server with apache 2.4.29. I’d like to let it cook for a few days, but at first glance this seems to be working fine. > > A patch would be great, yes, please open a PR with it when you have the > time :-) Awesome! I’ll let this keep running over the weekend, and if it continues to look good, I’ll send a patch over. Does that seem like enough time for testing? We don’t do a huge amount of hosting, this is only about 100 sites. So far, it’s not caused any issues. Thanks, Charles > > > -- > Mathieu Arnold [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iQEzBAEBCAAdFiEECbwhUg0jlYPK5QaKiZUhnP6GpPYFAlqQbfsACgkQiZUhnP6G pPZW8Af9Ed0x3O8fFTzWd3OLRZQx0IDkJ4TGefsgqTFNyW/XPvbdhHg9WTgEKmWR wIzjSEYfN59R7TwkmYZvqNGfAHaO2jkLjqGqigERbuEuPumvsHP+mQ1lD7Qfp7CV d7HxgMYdwbcrJm4+8p2+zOcmW54t99wDMLlUYvsCcgBUmN6duR/ILxXZeMS3mrHO 6ATNLIhMZAnlzWv9dB3/Cc+HnRR4x56aU1kzwlTfQOLkMn9TBJ7dcZPHakQDckLI O0LoDTpOfQ+W/6RdY8jMheZnX/s/elrccKZSKOd8r/M+/iJUzuFTxD41GnsLhg6f Z75TVn4FVz9tRdqrVO6HtgnUsSWoqQ== =Wpx0 -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3932758D-E9C3-4B02-93F3-8B90C0E7B4FE>