Date: Sat, 04 Mar 2017 14:57:47 -0800 From: John Baldwin <jhb@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: Pedro Giffuni <pfg@freebsd.org>, Slawa Olhovchenkov <slw@zxy.spb.ru>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314669 - head/sys/i386/conf Message-ID: <8173144.jrBJ3AIVVW@ralph.baldwin.cx> In-Reply-To: <20170305075947.K914@besplex.bde.org> References: <201703041504.v24F4HMh023937@repo.freebsd.org> <2368011.hGEX4V32U5@ralph.baldwin.cx> <20170305075947.K914@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, March 05, 2017 09:13:05 AM Bruce Evans wrote: > On Sat, 4 Mar 2017, John Baldwin wrote: > I think all the removal does on a plain 486 is move a runtime test so that > 486 CPUs no longer pass it, causing a panic for an "unsupported" CPU that > would work except the panic, and prevent reaching a single 486 optimization. > in bocpy(). The special support in initcpu() seems to be only to work > around bugs in incompatible 486 variants. The last time I looked at initcpu.c it wasn't clear how much of those old workarounds were for CPUs we don't support that could just be axed. > Fixes in this area should go the other way and remove the panics and the > cpu class stuff to implement them. The cpu class stuff used to mainly > give panics for newer CPUs that are backwards compatible but unknown. > Feature tests prevent that happening. All new x86 are 686s with optional > features. Plain 486 should work if it were classified as a 686 without > any features. I recently removed cpu_class from amd64 entirely. Removing it from i386 and just replying on cpu_feature* the way amd64 does would be fine with me. I'd probably remove all the I?86_CPU options in that case and just compile them all in. In regards to the TSC, that is one thing I've wondered if we should require for i386 to avoid some runtime checks and simplify the i386 code. There were 486's with a TSC even. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8173144.jrBJ3AIVVW>