Date: Mon, 9 Mar 2015 13:47:08 -0600 From: Warner Losh <imp@bsdimp.com> To: Ian Lepore <ian@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh <imp@FreeBSD.org> Subject: Re: svn commit: r279814 - head/sys/arm/conf Message-ID: <FCFDA1B3-0DE7-4F8F-A845-CF1FBD01E8C6@bsdimp.com> In-Reply-To: <1425916716.73796.28.camel@freebsd.org> References: <201503091543.t29FhYVu081001@svn.freebsd.org> <1425916716.73796.28.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Mar 9, 2015, at 9:58 AM, Ian Lepore <ian@FreeBSD.org> wrote: > > On Mon, 2015-03-09 at 15:43 +0000, Warner Losh wrote: >> Author: imp >> Date: Mon Mar 9 15:43:33 2015 >> New Revision: 279814 >> URL: https://svnweb.freebsd.org/changeset/base/279814 >> >> Log: >> Add the DTrace modules to the build, rather than only build the dtrace >> modules. >> >> Modified: >> head/sys/arm/conf/BEAGLEBONE >> >> Modified: head/sys/arm/conf/BEAGLEBONE >> ============================================================================== >> --- head/sys/arm/conf/BEAGLEBONE Mon Mar 9 15:31:33 2015 (r279813) >> +++ head/sys/arm/conf/BEAGLEBONE Mon Mar 9 15:43:33 2015 (r279814) >> @@ -31,7 +31,7 @@ makeoptions WITHOUT_MODULES="ahc" >> options KDTRACE_HOOKS # Kernel DTrace hooks >> options DDB_CTF # all architectures - kernel ELF linker loads CTF data >> makeoptions WITH_CTF=1 >> -makeoptions MODULES_OVERRIDE="opensolaris dtrace dtrace/lockstat dtrace/profile dtrace/fbt" >> +makeoptions MODULES_EXTRA="opensolaris dtrace dtrace/lockstat dtrace/profile dtrace/fbt" >> >> options HZ=100 >> options SCHED_4BSD # 4BSD scheduler >> >> > > Can we not do this, and instead just build all modules? I'm not sure > why we eliminate or override modules on some armv6 socs and not on > others, but I think it's a concept that's past it's sell-by date now. > If there are a few specific modules that aren't good for arm, we should > be fixing that in the modules makefiles. I assumed that this was here to give the folks working on Dtrace a bigger audience without breaking everybody if they are wrong. The prior change to the config file introduced MODULES_OVERRIDE, and it should have used MODULES_EXTRA because that’s what it is doing. I assume that this line will be eliminated when the sys/modules stuff turns on dtrace for arm. > I've got some WIP along these lines for beaglebone that's about ready to > commit, so I'm asking your opinion, not for you to do all the work. As for MODULES_OVERRIDE elimination, I’m all for it. I have some early WiP to filter modules in a smarter way (e.g. never compile USB modules if there can be no USB, ditto PCI). But that’s still some months away from coming to fruition. As we talked about on IRC, I’m cool with eliminating the MODULES_OVERRIDE for all armv6 config files. Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJU/fi9AAoJEGwc0Sh9sBEAnr0QAM5HA85MwjTQvCE4Zoylsyx1 vFAZQ7yRL5fz6WB0WVBf8Xybtn12XEpOmixqQ6Tkjng3P4yMOFjdbYEW1GJSGa/F t5VQbrn+WdraTIucpAhzTFbjNTfbPDxLYTuXSQiyJJCs5ECGOt0qVIn83PSxZ7Z6 bTcyWK/Vz5DlIe5gQ2VvgDuxzeFWHCrE+PA7nA66/p3jlUt7s1CSjbKomVJ2XKk8 K1YHLcGatciOXlp99zno0EUZw2/pa/y+GTJy4HMRTgCYjIXP3o/qQq5TlYYJcGEG 7eJ5SorUsxkwSFuTntbuQy51lUTX0b9yDBQvBOwo2eD6yJE2JsvA/uoTJR28PoSA Sbnt8a7wcD+41g3XguVKRIHacN4sZfe3kbS6AY8li++sqmQvj+8ufF1ns46ai795 qTK5dRgv1ZgDojn03g2eJHKoGYKs60lIXnX/lxCJzrXDEs1XOQwBBjiLxuKpLEPe hjlyJsWUDipat+tCIpxbR6JqrXuhFHnn0Z/glZUQR6G9XXXZpD4xgJ7dBgl01LtA uE6aYJl86o7PXb2tsIhTV0HMsjxqMuSl+fUgB0pzlbY00HlbSsz/oFg9mSJQGBW0 fyNSgAZmGoAwzMAFt7jIIZoY8cvs9WapEP8SaZzlzlaV8zafiZlIYxrmMoOKcfCx A3WP2UbdP91TvBJDtA4a =vxM7 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FCFDA1B3-0DE7-4F8F-A845-CF1FBD01E8C6>