Date: Mon, 13 Dec 2004 14:06:26 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c Message-ID: <37124.1102943186@critter.freebsd.dk> In-Reply-To: Your message of "Mon, 13 Dec 2004 13:33:10 %2B0200." <20041213113310.GB51149@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20041213113310.GB51149@ip.net.ua>, Ruslan Ermilov writes:
>Another issue:
>
>- boot without a diskette in the drive
>- insert a diskette #1 into the drive
>- newfs_msdos it
>- mount_msdosfs it
>- copy some files onto it
>- unmount it
>- insert another (possibly unformatted) diskette #2
>- mount_msdosfs it and find it somehow succeeds
>- list the contents of the diskette and find that it's identical
> to the contents of diskette #1, including MD5 checksums of
> all files
>
>This smells like a bufcache issue, but I may be wrong about it.
Sounds like the same thing.
Can you try this:
==== //depot/user/phk/phk_bufwork/sys/fs/msdosfs/msdosfs_vfsops.c#45 - /bang/p4/phk/phk_bufwork/sys/fs/msdosfs/msdosfs_vfsops.c ====
@@ -719,6 +719,7 @@
error_exit:
if (bp)
brelse(bp);
+ vinvalbuf(devvp, V_SAVE, NOCRED, td, 0, 0);
if (cp != NULL) {
DROP_GIANT();
g_topology_lock();
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?37124.1102943186>