Date: Mon, 23 Sep 2002 20:28:16 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Alfred Perlstein <bright@mu.org> Cc: Peter Wemm <peter@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/alpha/pci tsunamireg.h src/sys/boot/ia64/skiload main.c src/sys/i386/include npx.h src/sys/ia64/include reg.h signal.h src/sys/sys cdefs.h Message-ID: <20020923202345.K17455-100000@gamplex.bde.org> In-Reply-To: <20020923061917.GG6262@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 22 Sep 2002, Alfred Perlstein wrote: > * Peter Wemm <peter@FreeBSD.org> [020922 22:55] wrote: > > peter 2002/09/22 22:55:11 PDT > > ... > > There are over 400 __attribute__((packed)) to deal with, that can come > > later. I just want to use __packed in new code rather than add more > > gcc-ism's. > > I really like what you've done, however don't you think that the > places that do not have __packed/__aligned shouldn't have it defined > to nothing... therefore you can add: > > #ifndef __packed > #error you must define __packed or bad things will happen > #endif > #ifndef __aligned > #error you must define __aligned or bad things will happen > #endif > > Otherwise people may get compiled but very broken code > which most likely will be in critical things like device > drivers. I just noticed the -Wpacked warning. This can be used to detect unnecessary uses of __packed. __packed should only be used for historical or foreign poorly layed out structs. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020923202345.K17455-100000>