Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Jun 2009 06:12:08 +0000 (UTC)
From:      Alan Cox <alc@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r193201 - head/sys/kern
Message-ID:  <200906010612.n516C89j066174@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: alc
Date: Mon Jun  1 06:12:08 2009
New Revision: 193201
URL: http://svn.freebsd.org/changeset/base/193201

Log:
  Eliminate a comment describing code that was deleted over eight years ago.
  Move another comment to its proper place.  Fix a typo in a third comment.

Modified:
  head/sys/kern/vfs_bio.c

Modified: head/sys/kern/vfs_bio.c
==============================================================================
--- head/sys/kern/vfs_bio.c	Mon Jun  1 05:48:30 2009	(r193200)
+++ head/sys/kern/vfs_bio.c	Mon Jun  1 06:12:08 2009	(r193201)
@@ -638,13 +638,6 @@ bufinit(void)
 	hifreebuffers = 2 * lofreebuffers;
 	numfreebuffers = nbuf;
 
-/*
- * Maximum number of async ops initiated per buf_daemon loop.  This is
- * somewhat of a hack at the moment, we really need to limit ourselves
- * based on the number of bytes of I/O in-transit that were initiated
- * from buf_daemon.
- */
-
 	bogus_page = vm_page_alloc(NULL, 0, VM_ALLOC_NOOBJ |
 	    VM_ALLOC_NORMAL | VM_ALLOC_WIRED);
 }
@@ -1202,7 +1195,7 @@ brelse(struct buf *bp)
 		/*
 		 * Failed write, redirty.  Must clear BIO_ERROR to prevent
 		 * pages from being scrapped.  If the error is anything
-		 * other than an I/O error (EIO), assume that retryingi
+		 * other than an I/O error (EIO), assume that retrying
 		 * is futile.
 		 */
 		bp->b_ioflags &= ~BIO_ERROR;
@@ -2403,15 +2396,9 @@ vfs_setdirty(struct buf *bp) 
 	/*
 	 * Degenerate case - empty buffer
 	 */
-
 	if (bp->b_bufsize == 0)
 		return;
 
-	/*
-	 * We qualify the scan for modified pages on whether the
-	 * object has been flushed yet.
-	 */
-
 	if ((bp->b_flags & B_VMIO) == 0)
 		return;
 
@@ -2428,6 +2415,11 @@ vfs_setdirty_locked_object(struct buf *b
 
 	object = bp->b_bufobj->bo_object;
 	VM_OBJECT_LOCK_ASSERT(object, MA_OWNED);
+
+	/*
+	 * We qualify the scan for modified pages on whether the
+	 * object has been flushed yet.
+	 */
 	if (object->flags & (OBJ_MIGHTBEDIRTY|OBJ_CLEANING)) {
 		vm_offset_t boffset;
 		vm_offset_t eoffset;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906010612.n516C89j066174>