Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Mar 1996 11:25:58 -0500
From:      "Garrett A. Wollman" <wollman@lcs.mit.edu>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        current@freebsd.org
Subject:   Re: cvs commit:  src/sys/sys conf.h
Message-ID:  <9603121625.AA07546@halloran-eldar.lcs.mit.edu>
In-Reply-To: <199603120520.QAA31894@godzilla.zeta.org.au>
References:  <199603120520.QAA31894@godzilla.zeta.org.au>

next in thread | previous in thread | raw e-mail | index | archive | help
<<On Tue, 12 Mar 1996 16:20:43 +1100, Bruce Evans <bde@zeta.org.au> said:

>> (struct mbuf *)cmd, (struct mbuf *)data, (struct mbuf *)0));

> Actually, this is another point in favor of not making the ioctl cmd
> field long.  Longs are less likely to fit in pointers than ints.  The
> above would certainly fail for 16-bit pointers.

So what?  We are never going to have to deal with this situation.  The
only situations of relevance are:

32-bit int, 32-bit long, 32-bit pointer (all 32-bit systems)
32-bit int, 64-bit long, 64-bit pointer (Alpha)
64-bit int, 64-bit long, 64-bit pointer (Cray? ...will happen some day)

It works fine in the first case, and it avoids a GCC warning in the
second case.  Sounds like the right thing to me.

-GAWollman

--
Garrett A. Wollman   | Shashish is simple, it's discreet, it's brief. ... 
wollman@lcs.mit.edu  | Shashish is the bonding of hearts in spite of distance.
Opinions not those of| It is a bond more powerful than absence.  We like people
MIT, LCS, ANA, or NSA| who like Shashish.  - Claude McKenzie + Florent Vollant



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9603121625.AA07546>