Date: Thu, 24 Nov 2022 05:03:18 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: aa1913df7f3f - main - devel/py-responses: switch to USES=pytest Message-ID: <CAMHz58SQDCJqN=JZ4Ccgry2jgn%2BSjrsxkMKmn-hyuaFhP1TqHw@mail.gmail.com> In-Reply-To: <Y3uC6k/6H9HoKUd8@hades.panopticon> References: <202211071228.2A7CSOpv081761@gitrepo.freebsd.org> <CAMHz58TC1m=gOwUYxg25yhKbv2oJENVS_phYXo0bqdWN5WWuZA@mail.gmail.com> <Y3uC6k/6H9HoKUd8@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000545f6d05ee29a020 Content-Type: text/plain; charset="UTF-8" On Mon, Nov 21, 2022 at 9:58 PM Dmitry Marakasov <amdmi3@amdmi3.ru> wrote: > * Po-Chuan Hsieh (sunpoet@freebsd.org) wrote: > > On Mon, Nov 7, 2022 at 8:28 PM Dmitry Marakasov <amdmi3@freebsd.org> > wrote: > > > > The branch main has been updated by amdmi3: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id= > > aa1913df7f3f2f46e4b276b5c1b4e6d647ed70a4 > > > > commit aa1913df7f3f2f46e4b276b5c1b4e6d647ed70a4 > > Author: Dmitry Marakasov <amdmi3@FreeBSD.org> > > AuthorDate: 2022-11-07 12:14:58 +0000 > > Commit: Dmitry Marakasov <amdmi3@FreeBSD.org> > > CommitDate: 2022-11-07 12:27:46 +0000 > > > > devel/py-responses: switch to USES=pytest > > > > > > Please stop doing this. > > It should be USE_PYTHON=pytest, not USES=pytest. > > Furthermore, all existing USES=pytest should be changed to > USE_PYTHON=pytest. > > Sorry, but you can't just tell me to stop using the framework I've > introduced, without at least notifying me beforehand of that there's > now a duplicate framework which is now preferred. > In fact unfortunately I will not stop unless all the ports are > converted to USE_PYTHON=pytest and USES=pytest removed (which you > should've done in the first place to save everybodys time and avoid > ambiguity) as I have a lot of pending commits with migration to > USES=pytest I don't feel like redoing unless I have to. > > Thank you for your work anyway, this looks more flexible whan > USES=pytest. > Sorry for not reminding you earlier. I've submitted a review [1] of the earlier version to you, therefore I guess you're aware of this change. Months later, I committed the updated version which adds support for more test frameworks. Anyway, thank you for converting your ports to USE_PYTHON=pytest. Please feel free to enhance the pytest support in Mk/Uses/python.mk. [1] https://reviews.freebsd.org/D35069 > -- > Dmitry Marakasov . > amdmi3@amdmi3.ru ..: https://github.com/AMDmi3 https://amdmi3.ru/ > > --000000000000545f6d05ee29a020 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">On Mon, Nov 21, 2022 at 9:58 PM Dmitry Ma= rakasov <<a href=3D"mailto:amdmi3@amdmi3.ru" target=3D"_blank">amdmi3@am= dmi3.ru</a>> wrote:<br></div><div class=3D"gmail_quote"><blockquote clas= s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid r= gb(204,204,204);padding-left:1ex">* Po-Chuan Hsieh (<a href=3D"mailto:sunpo= et@freebsd.org" target=3D"_blank">sunpoet@freebsd.org</a>) wrote:<br> > On Mon, Nov 7, 2022 at 8:28 PM Dmitry Marakasov <<a href=3D"mailto:= amdmi3@freebsd.org" target=3D"_blank">amdmi3@freebsd.org</a>> wrote:<br> > <br> >=C2=A0 =C2=A0 =C2=A0The branch main has been updated by amdmi3:<br> > <br> >=C2=A0 =C2=A0 =C2=A0URL: <a href=3D"https://cgit.FreeBSD.org/ports/comm= it/?id=3D" rel=3D"noreferrer" target=3D"_blank">https://cgit.FreeBSD.org/po= rts/commit/?id=3D</a><br> >=C2=A0 =C2=A0 =C2=A0aa1913df7f3f2f46e4b276b5c1b4e6d647ed70a4<br> > <br> >=C2=A0 =C2=A0 =C2=A0commit aa1913df7f3f2f46e4b276b5c1b4e6d647ed70a4<br> >=C2=A0 =C2=A0 =C2=A0Author:=C2=A0 =C2=A0 =C2=A0Dmitry Marakasov <amd= mi3@FreeBSD.org><br> >=C2=A0 =C2=A0 =C2=A0AuthorDate: 2022-11-07 12:14:58 +0000<br> >=C2=A0 =C2=A0 =C2=A0Commit:=C2=A0 =C2=A0 =C2=A0Dmitry Marakasov <amd= mi3@FreeBSD.org><br> >=C2=A0 =C2=A0 =C2=A0CommitDate: 2022-11-07 12:27:46 +0000<br> > <br> >=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 devel/py-responses: switch to USES=3D= pytest<br> > <br> > <br> > Please stop doing this.<br> > It should be USE_PYTHON=3Dpytest, not USES=3Dpytest.<br> > Furthermore, all existing USES=3Dpytest should be changed to USE_PYTHO= N=3Dpytest.<br> <br> Sorry, but you can't just tell me to stop using the framework I've<= br> introduced, without at least notifying me beforehand of that there's<br= > now a duplicate framework which is now preferred.</blockquote><blockquote c= lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli= d rgb(204,204,204);padding-left:1ex"><br> In fact unfortunately I will not stop unless all the ports are<br> converted to USE_PYTHON=3Dpytest and USES=3Dpytest removed (which you<br> should've done in the first place to save everybodys time and avoid<br> ambiguity) as I have a lot of pending commits with migration to<br> USES=3Dpytest I don't feel like redoing unless I have to.<br> <br> Thank you for your work anyway, this looks more flexible whan<br> USES=3Dpytest.<br></blockquote><div><br></div><div><div>Sorry for=C2=A0not = reminding you=C2=A0earlier. I've submitted a review [1] of the earlier = version to you, therefore I guess you're aware of this change.</div><di= v>Months later, I committed the updated version which adds=C2=A0support for= =C2=A0more test=C2=A0frameworks.<br></div><div><br></div><div>Anyway, thank= you for converting your ports to USE_PYTHON=3Dpytest.</div><div>Please fee= l free to enhance the pytest support in Mk/Uses/<a href=3D"http://python.mk= ">python.mk</a>.</div><div><br></div><div>[1]=C2=A0<a href=3D"https://revie= ws.freebsd.org/D35069" target=3D"_blank">https://reviews.freebsd.org/D35069= </a>=C2=A0</div></div><div>=C2=A0<br></div><blockquote class=3D"gmail_quote= " style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);= padding-left:1ex"> -- <br> Dmitry Marakasov=C2=A0 =C2=A0.<br> <a href=3D"mailto:amdmi3@amdmi3.ru" target=3D"_blank">amdmi3@amdmi3.ru</a>= =C2=A0 ..:=C2=A0 <a href=3D"https://github.com/AMDmi3" rel=3D"noreferrer" t= arget=3D"_blank">https://github.com/AMDmi3</a>=C2=A0 <a href=3D"https://amd= mi3.ru/" rel=3D"noreferrer" target=3D"_blank">https://amdmi3.ru/</a><br>; <br> </blockquote></div></div> --000000000000545f6d05ee29a020--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58SQDCJqN=JZ4Ccgry2jgn%2BSjrsxkMKmn-hyuaFhP1TqHw>