Date: Mon, 4 Aug 2014 10:24:44 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Garrett Cooper <ngie@freebsd.org> Subject: Re: svn commit: r269505 - head/libexec/rtld-elf/tests/target Message-ID: <F63D0031-AE8E-4125-96F1-9879C959F75D@gmail.com> In-Reply-To: <20140804185707.P7764@besplex.bde.org> References: <53df1ed9.5830.34b38bca@svn.freebsd.org> <20140804185707.P7764@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Hi Bruce! On Aug 4, 2014, at 2:23 AM, Bruce Evans <brde@optusnet.com.au> wrote: > On Mon, 4 Aug 2014, Garrett Cooper wrote: ... > I hope this fixes the error found by "make checkdpadd". -L is too hard > for the current "make checkdpadd" to handle. Old aout versions worked > better using linker support. They also found the correct dependencies > (on shared libraries for shared linkage, not the pseudo-dependenci on > the hard-coded static librar for shared linkage). Thank you for the reminder about that make target :). > "make checkdpadd" currently finds broken 143 makefiles with inconsistent > DPADD. 62 of them are for clang. Most of these misuse DPADD for > headers. The next largest source of errors is libtermcapw. LIBTERMCAPW > is missing in bsd.libnames.mk. This breaks about 29 makefiles where > LIBTERMCAP was blindly replaced by LIBTERMCAPW. bsd.libnames.mk and > DPADD were unnecessary with the old aout versions. I’ll file bugs for any issues I find and work with maintainers to fix the issues. I’m not sure if you’re on Phabricator, but I’d be happy to add you to the reviews if you would like. Thanks! -Garrett [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJT38HcAAoJEMZr5QU6S73eUtYIAJe0JVH2/KnnyuJTHzExxiY9 TlPUYYO22XTW7JWw3tBy8SU8KnU403+5slffJdHYg3WWHh2/DMWCNQs5Rs0Vhobl hWrTTEmOr5Rz6T2wRqiFb7iwra/kMF1Qb4s7DEYxycHFwApCNv0ROhWO+rpD/Bac 9JOo+cMjs8u8lSVpjLtJ5cknzl7opH/WkcFGC7xSIfKOBHYg2owH8K381J+2FMhM 3EK+XYQpI5AM9NcGlwYokU0yFThx4ugWXewR92nU3rl9ABNd0W76K0wXM0Mo4Iuz RqsTtDPmieyb9VFPGeWswNsWKCbdDYU7cijN7llhQ3uDREVPZrUFtICsyUx6yOE= =BwSf -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F63D0031-AE8E-4125-96F1-9879C959F75D>