Date: Mon, 17 Jul 2023 20:31:41 +0200 From: tuexen@freebsd.org To: Warner Losh <imp@bsdimp.com> Cc: John Baldwin <jhb@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d3152ab23e0e - main - tcbpcb: Always define t_osd Message-ID: <98645F20-A699-4C32-8485-7ECF4C95E8A6@freebsd.org> In-Reply-To: <CANCZdfp-1zbXXMenHS3rRzC8-8bR-dgOttMPYdGVBBi0Lt25zA@mail.gmail.com> References: <202307171735.36HHZonv063454@gitrepo.freebsd.org> <ba89809b-0af3-8eb6-afd2-68606450f186@FreeBSD.org> <CANCZdfp-1zbXXMenHS3rRzC8-8bR-dgOttMPYdGVBBi0Lt25zA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 17. Jul 2023, at 19:54, Warner Losh <imp@bsdimp.com> wrote: >=20 >=20 >=20 > On Mon, Jul 17, 2023 at 11:52=E2=80=AFAM John Baldwin = <jhb@freebsd.org> wrote: > On 7/17/23 10:35 AM, Warner Losh wrote: >> The branch main has been updated by imp: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dd3152ab23e0e7bee5a0f988ecca2a118= 7ab82057 >>=20 >> commit d3152ab23e0e7bee5a0f988ecca2a1187ab82057 >> Author: Warner Losh <imp@FreeBSD.org> >> AuthorDate: 2023-07-17 17:22:45 +0000 >> Commit: Warner Losh <imp@FreeBSD.org> >> CommitDate: 2023-07-17 17:22:45 +0000 >>=20 >> tcbpcb: Always define t_osd >>=20 >> Always define t_osd. congestion control modules access it >> unconditionally. This fixes the build. >>=20 >> However, this is, at best, a temporary band-aide until the >> larger issues are sorted. >>=20 >> Sponsored by: Netflix >=20 > FWIW, I find that #ifdef's based on kernel options in "core" = structures like this > shared with modules is a recipe for disaster. >=20 > Agreed 100% Just trying to get to closure on that concept with all the = concerned > parties.... Just discussed this issue with rrs@. The proposal includes this. Will = bring up a review shortly. I will put you on the reviewers list. Best regards Michael >=20 > Warner=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?98645F20-A699-4C32-8485-7ECF4C95E8A6>