Date: Thu, 23 May 2024 07:54:58 -0600 From: Warner Losh <imp@bsdimp.com> To: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl> Cc: Peter Eriksson <pen@lysator.liu.se>, FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: Trying to understand CAM (and the cciss driver) Message-ID: <CANCZdfox_oVN9maQvMc43ECznDu-5d7jk8rh5bDmOcQ-1SGe1Q@mail.gmail.com> In-Reply-To: <Zk9CewNj_X5KdcOa@plan-b.pwste.edu.pl> References: <087AB4C4-9CE0-4024-8E1B-4C636014C8CC@lysator.liu.se> <Zk9CewNj_X5KdcOa@plan-b.pwste.edu.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000545d6806191f667e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 23, 2024, 7:20=E2=80=AFAM Marek Zarychta <zarychtam@plan-b.pwst= e.edu.pl> wrote: > Dnia Thu, May 09, 2024 at 07:58:32PM +0200, Peter Eriksson napisa=C5=82(a= ): > > Hi, > > > > I=E2=80=99m trying to fix a bug in the cciss driver that has been there > =E2=80=9Cforever=E2=80=9D when using it with an HP H241 SAS HBA card. > > The driver works fine when all (SAS, spinning rust) drives are behaving > well, but when some of them are starting to go bad it often goes into spi= n > and either hangs the kernel or panics. I=E2=80=99ve been trying to add > instrumentation to it in order to pin-point the problem and have been > attempting some workarounds (like clearing cr_complete since without that > hack sometime the driver get many many non-busy repeated requests with th= e > same =E2=80=9Ctag=E2=80=9D and then It panics with: > (...) > > > > - Any suggestions? (Probably not but I thought I=E2=80=99d ask anyway := -) > > > > Hello Peter, > > I have no suggestion but a question. Does the panic happen with > https://reviews.freebsd.org/D25155 applied ? I am using your patch from > this review with a few drives. It's handy and still builds fine on > 15-CURRENT. > I think he'll still get panics from that since his panics were from bugs in the recovery code, i think, and that patch doesn't really change that code. There may be more diagnostics produced from that code, so it may be worth trying... Warner Cheers > > -- > Marek Zarychta > > --000000000000545d6806191f667e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Thu, May 23, 2024, 7:20=E2=80=AFAM Marek Zarychta &= lt;<a href=3D"mailto:zarychtam@plan-b.pwste.edu.pl">zarychtam@plan-b.pwste.= edu.pl</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"m= argin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Dnia Thu, May= 09, 2024 at 07:58:32PM +0200, Peter Eriksson napisa=C5=82(a):<br> > Hi,<br> > <br> > I=E2=80=99m trying to fix a bug in the cciss driver that has been ther= e =E2=80=9Cforever=E2=80=9D when using it with an HP H241 SAS HBA card. <br= > > The driver works fine when all (SAS, spinning rust) drives are behavin= g well, but when some of them are starting to go bad it often goes into spi= n and either hangs the kernel or panics. I=E2=80=99ve been trying to add in= strumentation to it in order to pin-point the problem and have been attempt= ing some workarounds (like clearing cr_complete since without that hack som= etime the driver get many many non-busy repeated requests with the same =E2= =80=9Ctag=E2=80=9D and then It panics with: <br> (...)<br> > <br> > - Any suggestions? (Probably not but I thought I=E2=80=99d ask anyway = :-)<br> > <br> <br> Hello Peter,<br> <br> I have no suggestion but a question. Does the panic happen with<br> <a href=3D"https://reviews.freebsd.org/D25155" rel=3D"noreferrer noreferrer= " target=3D"_blank">https://reviews.freebsd.org/D25155</a>; applied ? I am u= sing your patch from<br> this review with a few drives. It's handy and still builds fine on<br> 15-CURRENT.<br></blockquote></div></div><div dir=3D"auto"><br></div><div di= r=3D"auto">I think he'll still get panics from that since his panics we= re from bugs in the recovery code, i think, and that patch doesn't real= ly change that code. There may be more diagnostics produced from that code,= so it may be worth trying...</div><div dir=3D"auto"><br></div><div dir=3D"= auto">Warner</div><div dir=3D"auto"><br></div><div dir=3D"auto"><div class= =3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8= ex;border-left:1px #ccc solid;padding-left:1ex"> Cheers<br> <br> -- <br> Marek Zarychta<br> <br> </blockquote></div></div></div> --000000000000545d6806191f667e--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfox_oVN9maQvMc43ECznDu-5d7jk8rh5bDmOcQ-1SGe1Q>