Date: Fri, 26 Jun 2026 15:18:35 +0000 From: Siva Mahadevan <siva@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: c5be733527f1 - stable/15 - msun/logarithm_test: expect_fail log1p_accuracy_tests in the correct spot Message-ID: <6a3e984b.2298a.65489194@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch stable/15 has been updated by siva: URL: https://cgit.FreeBSD.org/src/commit/?id=c5be733527f1e4fabc83e35c87e26afd002e08e2 commit c5be733527f1e4fabc83e35c87e26afd002e08e2 Author: Siva Mahadevan <siva@FreeBSD.org> AuthorDate: 2026-06-17 17:04:54 +0000 Commit: Siva Mahadevan <siva@FreeBSD.org> CommitDate: 2026-06-26 15:16:44 +0000 msun/logarithm_test: expect_fail log1p_accuracy_tests in the correct spot While here, remove the conditional on the "ci" config var to ensure that this is reproducible locally as well. This fixes a case where we are expecting a fail before the failing ATF_CHECK_* assertion happens. Found in a CI failure here: https://ci.freebsd.org/job/FreeBSD-main-riscv64-test/16608/testReport/lib.msun/logarithm_test/log1p_accuracy_tests/ PR: 253984 Fixes: 405188aeac540f7666dfde37c2f32d222119f56e MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D57351 (cherry picked from commit 19af9c77acc912e4bf90a667924f5f4ff78a7759) --- lib/msun/tests/logarithm_test.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/msun/tests/logarithm_test.c b/lib/msun/tests/logarithm_test.c index df1fcdc8627d..a605fa6a6bfc 100644 --- a/lib/msun/tests/logarithm_test.c +++ b/lib/msun/tests/logarithm_test.c @@ -249,10 +249,6 @@ ATF_TC_BODY(accuracy_tests, tc) ATF_TC_WITHOUT_HEAD(log1p_accuracy_tests); ATF_TC_BODY(log1p_accuracy_tests, tc) { -#if LDBL_MANT_DIG > 64 - if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false)) - atf_tc_expect_fail("https://bugs.freebsd.org/253984"); -#endif #if defined(__riscv) atf_tc_expect_death("https://bugs.freebsd.org/290099"); #endif @@ -260,6 +256,9 @@ ATF_TC_BODY(log1p_accuracy_tests, tc) 1.82321546859847114303367992804596800640e-1L, FLT_ULP()); test_tol(log1p, 0x0.3333333333333p0, 1.82321556793954589204283870982629267635e-1L, DBL_ULP()); +#if LDBL_MANT_DIG > 64 + atf_tc_expect_fail("https://bugs.freebsd.org/253984"); +#endif test_tol(log1pl, 0x0.33333333333333332p0L, 1.82321556793954626202683007050468762914e-1L, LDBL_ULP());home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a3e984b.2298a.65489194>