Date: Sat, 14 Jul 2018 22:39:11 +0200 (CEST) From: Gerald Pfeifer <gerald@pfeifer.com> To: Dmitry Marakasov <amdmi3@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470444 - head/lang/gcc-ecj45 Message-ID: <alpine.LSU.2.21.1807142237341.5444@anthias.pfeifer.com> In-Reply-To: <201805200904.w4K94BAh007929@repo.freebsd.org> References: <201805200904.w4K94BAh007929@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 20 May 2018, Dmitry Marakasov wrote: > Author: amdmi3 > Date: Sun May 20 09:04:10 2018 > New Revision: 470444 > URL: https://svnweb.freebsd.org/changeset/ports/470444 > > Log: > - Add LICENSE > - Cosmetic fixes > - Add NO_ARCH > > Approved by: portmgr blanket I'm not really sure "cosmetic fixes" are covered by portmgr blanket, especially where something is a style issue. For example... > Modified: head/lang/gcc-ecj45/Makefile > ============================================================================== > -EXTRACT_SUFX= > -EXTRACT_ONLY= > +EXTRACT_SUFX= # empty > +EXTRACT_ONLY= # empty ...I preferred the original version of that and do not see this as a real improvement. > +LICENSE= EPL > +NO_ARCH= yes Thanks for adding these two, on the other hand. Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1807142237341.5444>