Date: Thu, 18 Dec 2003 01:46:13 -0600 From: "Brandon D. Valentine" <brandon@dvalentine.com> To: nc-rotherdo@netcologne.de Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: prying x11-wm/wmakerconf loose from gnome Message-ID: <20031218074613.GA8284@geekpunk.net>
next in thread | raw e-mail | index | archive | help
TO Dominik (wmakerconf maintainer),
freebsd-ports (gnome2wmaker maintainer),
and freebsd-gnome,
My apologies for the crosspost, but I'm looking for some advice on
eliminating this:
% pkg_info -r wmakerconf-2.8.1 | wc -l
68
The wmakerconf port does not require gnome, except that it does. The
Makefile for wmakerconf contains this:
[...]
USE_GNOME= imlib
WANT_GNOME= yes
[...]
.if defined(HAVE_GNOME)
BUILD_DEPENDS+= gnome2wmaker:${PORTSDIR}/x11-wm/gnome2wmaker
RUN_DEPENDS+= gnome2wmaker:${PORTSDIR}/x11-wm/gnome2wmaker
PLIST_SUB+= GNOME:=""
.else
PLIST_SUB+= GNOME:="@comment "
.endif
[...]
'.if defined(HAVE_GNOME)' will always evaluate to true as the port has
just declared its dependency on imlib above. Thus, wmakerconf _always_
adds gnome2wmaker to its dependency list. This is a non-trivial
addition as gnome2wmaker's Makefile uses the old 'USE_GNOME=yes' syntax
which sucks in all of gnomeprefix, gnomehack and gtkhtml. gtkhtml
pretty much takes care of sucking the rest of gnome in by declaring
'USE_GNOME=gnomehack gnomeprefix gnomehier glibwww libghttp libcapplet
gal'.
In this way we end up with 68 dependencies for a simple little program
like wmakerconf.
I would like to submit some PRs w/ patches to clean all of this up (or
have a committer reading this just go and fix it without hassling around
with gnats). Both x11-wm/wmakerconf and x11-wm/gnome2wmaker need to be
fixed.
gnome2wmaker needs to comply with the new bsd.gnome.mk policy regarding
USE_GNOME, i.e. no more 'USE_GNOME=yes'. It should do this by setting
USE_GNOME to whichever gnome component provides "menus". gnome2wmaker's
purpose is to insert the gnome menu into the windowmaker menu, so it
should require the part of gnome that provides menus. It is not
immediately clear to me which component that might be. Perhaps one of
the freebsd-gnome boys can shed some light on that.
wmakerconf needs to be updated so that instead of testing to see if
HAVE_GNOME is defined, it checks HAVE_GNOME for the same "menu"
component. If that component is installed, then it should add
gnome2wmaker to its dependencies.
Which of the gnome components contains the "menus" and should be tested
against? Should I submit PRs+patches or is there some ports or gnome
committer who would prefer to clean these up? They both should be
simple to fix.
Thanks,
Brandon D. Valentine
--
brandon@dvalentine.com http://www.geekpunk.net
Pseudo-Random Googlism: solstice is a time of self reflection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031218074613.GA8284>