Date: Wed, 31 Jan 2007 11:23:44 -0500 (EST) From: Andrew Gallatin <gallatin@cs.duke.edu> To: Scott Long <scottl@samsco.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/mxge if_mxge.c Message-ID: <17856.49808.122662.571245@grasshopper.cs.duke.edu> In-Reply-To: <45C0BC2F.9060303@samsco.org> References: <200701311547.l0VFliLC039432@repoman.freebsd.org> <45C0BC2F.9060303@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Scott Long writes: > Yeah, I can't stress enough that busdma maps are opaque handles and > should always be handled like they are valid. It's only an > implementation detail that they are often NULL on i386 and amd64. It was overly cautious resource freeing code, influenced by lots of programming on other OSes, where free(NULL) is a panic :( I was able to simplify it some.. FWIW, I've got one small leak of 2 "temp" items left that I'm going to wait for dtrace to track down. Drew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?17856.49808.122662.571245>