Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Jun 2011 23:22:35 +0000 (UTC)
From:      Craig Rodrigues <rodrigc@FreeBSD.org>
To:        cvs-src-old@freebsd.org
Subject:   cvs commit: src/lib/libstand tftp.c
Message-ID:  <201106152322.p5FNMhCI077316@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
rodrigc     2011-06-15 23:22:35 UTC

  FreeBSD src repository

  Modified files:
    lib/libstand         tftp.c 
  Log:
  SVN rev 223128 on 2011-06-15 23:22:35Z by rodrigc
  
  Bring back following change which was undone in previous commit:
  
      ------------------------------------------------------------------------
      r172854 | marius | 2007-10-21 10:03:18 -0700 (Sun, 21 Oct 2007) | 16 lines
      Changed paths:
         M /head/lib/libstand/tftp.c
  
      - Given that we tell the compiler that struct ip is packed and 32-bit
        aligned, GCC 4.2.1 also generates code for sendudp() that assumes
        this alignment. GCC 4.2.1 however doesn't 32-bit align wbuf, causing
        the loader to crash due to an unaligned access of wbuf in sendudp()
        when netbooting sparc64. Solve this by specifying wbuf as packed and
        32-bit aligned, too. As for lastdata and readudp() this currently is
        no issue when compiled with GCC 4.2.1, though give lastdata the same
        treatment as wbuf for consistency and possibility of being affected
        in the future. [1]
      - Sprinkle const on a lookup table.
      ------------------------------------------------------------------------
  
  Revision  Changes    Path
  1.20      +4 -4      src/lib/libstand/tftp.c



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201106152322.p5FNMhCI077316>