Date: Sat, 20 Apr 2019 09:32:06 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: Enji Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346443 - head/tests/sys/opencrypto Message-ID: <E7F620F3-65D1-472B-895F-3AFABB4DE75F@gmail.com> In-Reply-To: <FB564B5D-127D-48E8-8C24-A954A8EFCCD3@gmail.com> References: <201904201543.x3KFhSAl037969@repo.freebsd.org> <fe23c154-32e3-eac6-7b1d-0ad09a938071@FreeBSD.org> <FB564B5D-127D-48E8-8C24-A954A8EFCCD3@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 20, 2019, at 9:31 AM, Enji Cooper <yaneurabeya@gmail.com> = wrote: >=20 >=20 >> On Apr 20, 2019, at 9:30 AM, John Baldwin <jhb@freebsd.org = <mailto:jhb@freebsd.org>> wrote: >>=20 >> On 4/20/19 8:43 AM, Enji Cooper wrote: >>> Author: ngie >>> Date: Sat Apr 20 15:43:28 2019 >>> New Revision: 346443 >>> URL: https://svnweb.freebsd.org/changeset/base/346443 = <https://svnweb.freebsd.org/changeset/base/346443>; >>>=20 >>> Log: >>> tests/sys/opencrypto: fix whitespace per PEP8 >>>=20 >>> Replace hard tabs with four-character indentations, per PEP8. >>>=20 >>> This is being done to separate stylistic changes from the tests = from functional >>> ones, as I accidentally introduced a bug to the tests when I used = four-space >>> indentation locally. >>>=20 >>> No functional change. >>=20 >> Wow, this is really painful for the 4-5 open reviews I have = outstanding as it >> makes a merge disaster. >=20 > Sorry ;_;=E2=80=A6 Being more constructive: I will back out the change, then = reapply it later. Thank you, -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E7F620F3-65D1-472B-895F-3AFABB4DE75F>