Date: Fri, 24 Feb 2017 13:02:48 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Ian Lepore <ian@freebsd.org> Cc: Ngie Cooper <ngie@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314189 - head/lib/libcam Message-ID: <769272AC-D30C-4C69-B4D3-9805B9FFC28D@gmail.com> In-Reply-To: <1487950593.25520.20.camel@freebsd.org> References: <201702240624.v1O6OdRr094467@repo.freebsd.org> <1487950593.25520.20.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Feb 24, 2017, at 07:36, Ian Lepore <ian@freebsd.org> wrote: > > On Fri, 2017-02-24 at 06:24 +0000, Ngie Cooper wrote: >> Author: ngie >> Date: Fri Feb 24 06:24:39 2017 >> New Revision: 314189 >> URL: https://svnweb.freebsd.org/changeset/base/314189 >> >> Log: >> Fix up NULL/'\0' uses and fix 2 derefs after NULL >> >> MFC after: 2 weeks >> Reported by: Coverity >> CID: 1018898, 1018899 >> Differential Revision: https://reviews.freebsd.org/D6142 >> Sponsored by: Dell EMC Isilon >> >> Modified: >> head/lib/libcam/scsi_cmdparse.c >> >> Modified: head/lib/libcam/scsi_cmdparse.c >> ===================================================================== >> ========= >> --- head/lib/libcam/scsi_cmdparse.c Fri Feb 24 01:39:12 2017 >> (r314188) >> +++ head/lib/libcam/scsi_cmdparse.c Fri Feb 24 06:24:39 2017 >> (r314189) >> @@ -128,14 +128,14 @@ do_buff_decode(u_int8_t *buff, size_t le >> *(va_arg(*ap, int *)) = (ARG); \ >> assigned++; \ >> } \ >> - field_name[0] = 0; \ >> + field_name[0] = '\0'; \ > > Is coverity seriously complaining about using 0 instead of '\0'? What > possible *real* benefit (not just shutting up coverity) does this churn > bring? Warner made the same comment. It was actually a combination of issues brought up by Coverity and coccinelle (badzero.cocci). The forward-NULL CIDs noted were pointed out by Coverity. The NULL/‘\0’ use issues were pointed out by coccinelle. Thanks! -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYsJ94AAoJEPWDqSZpMIYVniIQANU5r6hhcQVnXMTZHgGotzuk dQkaW876l2MnzH32vkCkgyeeBQyMIsX1Mb7kU6W3NsDy8A/FTcQyhYXJQtUn1Kv8 Pb4tbwz7xczJ7USL65boY5k7ArCSJKHCoff3tt1i/UkhSQ8S96+/K+CHY+2BveFU 2F4A9AlKCBA2Kyq8iWmgxUa59cj6jzm3BwT4CrxfMa9AJZNsYnMDrdUELCI0ZD/z yR7qIZ3MLMg/U6UKnA7uYeqnTFiiuNw6ofxlA3hFhxcBxa0jbggu+zVshke7oY/1 z5zZx4REsgJ4RRT25CAYURwMQZprRR9SpIobYLFzht+5derzXUzpCLW3W08fOgr9 JbqxbFGJMLXCdGDVn7JE0A/Qv7GKWt0Yese9m2en21N51ZyWbl70AOfrDbadlGiy F9OGI7HhQdpsHtNsIXY3j1OxwzYUniln7TLcxKetGTERfWsikhGvvz3dwCf+OYQk Ptyb2MNDH8AD9gHmxIfX/6gWrhohMtD8aV9H1zJbaKmsphXBy1vjWoo1XFUxYJ3H 7RJlzcWrK7LSev2MU3bwHOqhyEvX99BM+kqOM3vovtQg+v0t4QtFRzhBSD8y5fam fsFRV3kyPFrQx7uwTBalkUfQPyYoMiDhipS3I+V8JFBAGYGuGgo7y3bZk6fRgvip IIBBo3MAPywWIfYBLv7g =qawt -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?769272AC-D30C-4C69-B4D3-9805B9FFC28D>