Date: Tue, 23 May 2000 13:35:35 +0200 From: Martin Cracauer <cracauer@cons.org> To: "Andrey A. Chernov" <ache@FreeBSD.ORG> Cc: Martin Cracauer <cracauer@cons.org>, Kris Kennaway <kris@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: ports/shells/bash2 Makefile ports/shells/bash2/files md5 ports/shells/bash2/patches patch-ab patch-ac patch-ad patch-ae patch-af Message-ID: <20000523133533.A11542@cons.org> In-Reply-To: <20000523035703.A57649@freebsd.org>; from ache@FreeBSD.ORG on Tue, May 23, 2000 at 03:57:03AM -0700 References: <200005072033.NAA29021@freefall.freebsd.org> <Pine.BSF.4.21.0005071518240.38184-100000@freefall.freebsd.org> <20000507165758.A81840@freebsd.org> <20000523122429.A36447@cons.org> <20000523035703.A57649@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii In <20000523035703.A57649@freebsd.org>, Andrey A. Chernov wrote: > On Tue, May 23, 2000 at 12:24:29PM +0200, Martin Cracauer wrote: > > The failglob variable has been submitted to Chet Ramey (the bash > > maintainer) and is accepted for new bash versions. > > What you mean by accepted? This addition is not in 2.04 Releases where the minor number is even are strictly bugfix-only releases, so it is not in 2.04, although it was accepted before 2.04. As I feel the option improves conformance to the "BSD" way, I added it to the port in advance: cat *.foo when no *.foo exist should not call cat with the literal string '*.foo', but instead fail with an error, like csh does. Or in other word, if you want to pass metachars, you have to quote then. The requirement for quoting should not depend on the contents of the current directory. This option is turned off by default. > > Before adding this to the FreeBSD port (until the official one is > > released), I asked you by personal mail and the freebsd-port mailing > > list. Noone objected and you did not respond (although you are listed > > as maintainer of the port). > > I not object of adding this patch. The reason it was dropped is that it is not > apply to 2.04 and personally I do not plan to support it. > > > As the very least you could have checked back with me before just > > dropping it (even without knowing what it does, as you admint above). > > Now we send our users through an additional round of removed and added > > feature. > > No, I just upgrade parts I know by myself. It is your responsibility to > maintain your additions. OK, thats fine for me, but you should send a short notice to the committer of additions you remove, especially when you didn't understand them. > > You also silently removed static linking from the port. We once had > > Where was static linking exacly? I don't remember I remove it. You removed CONFIGURE_ENV= LDFLAGS=-static in version 1.34 of Makefile (ELF updates) fork()ing without exec()ing becomes more expensive when linked dynamically. Many shellscript (especially those with much backquoting and subshells in parenthesis) become slow and -what's more important- punish other processes by loading the VM system with mapping requests. ~(gilgamesch)69% gcc -Wall -o l l.c ~(gilgamesch)70% ctime ./l 0:05.46 5.46 sec 96% 1312 KB maxres 20 KB avg 0/100051 faults ~(gilgamesch)71% ctime ./l 0:05.36 5.36 sec 98% 1312 KB maxres 20 KB avg 0/100051 faults ~(gilgamesch)72% gcc -Wall -static -o l l.c ~(gilgamesch)74% ctime ./l 0:02.02 2.02 sec 95% 80 KB maxres 19 KB avg 0/20010 faults ~(gilgamesch)75% ctime ./l 0:02.02 2.02 sec 96% 80 KB maxres 20 KB avg 0/20010 faults Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer <cracauer@cons.org> http://www.cons.org/cracauer/ Tel.: (private) +4940 5221829 Fax.: (private) +4940 5228536 --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="l.c" #include <stdio.h> #include <sys/types.h> #include <unistd.h> #include <sys/types.h> #include <sys/wait.h> #include <signal.h> int main(void) { int i; int pid; for (i = 0; i < 10000 ; i++) { pid = fork(); if (pid) wait(NULL); else exit(0); } return 0; } --wRRV7LY7NUeQGEoC-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000523133533.A11542>