Date: Sat, 6 Dec 2014 18:50:28 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Dimitry Andric <dim@FreeBSD.org> Cc: FreeBSD CURRENT <freebsd-current@freebsd.org>, Garrett Cooper <yaneurabeya@gmail.com> Subject: Re: Build failed in Jenkins: Build-UFS-image #599 Message-ID: <20141206165027.GJ97072@kib.kiev.ua> In-Reply-To: <7A7677F9-AD1B-436C-9A49-054F7CD6BBC4@FreeBSD.org> References: <1052304530.8.1417827164793.JavaMail.jenkins@jenkins-9.freebsd.org> <D290A7DA-0AED-4810-A1B1-470E35542292@gmail.com> <7A7677F9-AD1B-436C-9A49-054F7CD6BBC4@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On Sat, Dec 06, 2014 at 04:01:26PM +0100, Dimitry Andric wrote: > [trimmed CC list to -current] > > On 06 Dec 2014, at 04:59, Garrett Cooper <yaneurabeya@gmail.com> wrote: > > 2. Why isn?t this value determined once in Makefile.inc1 (per build phase), then passed down from there > > Because you are supposed to be able to build stuff in a subdirectory, > without invoking the full top-level Makefile infrastructure. The actual > infrastructure is in share/mk/bsd.*.mk, in fact. > > > > (I?ve already considered the scenario where someone explicitly sets CC in a non-toplevel Makefile, which is a problem, but an outlier rather than the norm)? AFAICT, it gets recomputed for every recursive make, which contributes to useless forking for something that honestly doesn?t change all that often/at all. > > This is indeed a pity, and if you know a better solution, let's hear it, > please. :-) > Why not also put this information into some environment variables with known ugly names, in top-level. Then, the lower-level calls of infrastructure first check the vars, and recalculate the compiler specific info if vars are absent. Use information from vars if present.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141206165027.GJ97072>