Date: Thu, 17 Aug 2000 10:23:17 -0700 (PDT) From: Archie Cobbs <archie@whistle.com> To: Hajimu UMEMOTO <ume@mahoroba.org> Cc: freebsd-current@freebsd.org Subject: Re: 5.0 snapshot install problem Message-ID: <200008171723.KAA94975@bubba.whistle.com> In-Reply-To: <20000818.005433.112615995.ume@mahoroba.org> from Hajimu UMEMOTO at "Aug 18, 2000 00:54:33 am"
next in thread | previous in thread | raw e-mail | index | archive | help
Hajimu UMEMOTO writes:
> archie> I'm having trouble installing the 5.0-20000815-CURRENT snapshot.
> archie> The problem seems to be broken behavior in the installer FTP client.
> archie> My firewall requires using passive mode. The installer asks the
> archie> FTP server for passive mode (using PASV), but then it bogusly asks
> archie> for active mode (using the PORT command) immediately afterwards.
> archie> Yes I selected 'passive mode ftp' for the transfer method.
>
> It seems -CURRENT's libftpio.c always set passive flag according to
> environment variable FTP_PASSIVE_MODE. Then, PASV/PORT selection
> obeys only FTP_PASSIVE_MODE and direction of sysinstall is ignored.
> Does this patch fix your problem?
Don't know, because I'd have to create new install floppies first..
But I don't think this patch would fix things.. I don't see any
logical flaw there. ftpPassive() just checks that the toggle is
set to the right value -- it doesn't necessarily do anything.
The only way I can see that PASV would be sent immediately followed
by PORT is due to incorrect logic in the installer (or possibly a
bug in libftpio's parsing of the 227 reply).
-Archie
> Index: lib/libftpio/ftpio.c
> ===================================================================
> RCS file: /home/ncvs/src/lib/libftpio/ftpio.c,v
> retrieving revision 1.37
> diff -u -u -r1.37 ftpio.c
> --- lib/libftpio/ftpio.c 2000/07/10 10:00:20 1.37
> +++ lib/libftpio/ftpio.c 2000/08/17 15:40:43
> @@ -550,7 +550,8 @@
> {
> char *cp = getenv("FTP_PASSIVE_MODE");
>
> - ftpPassive(fp, (cp && strncasecmp(cp, "no", 2)));
> + if (cp)
> + ftpPassive(fp, strncasecmp(cp, "no", 2));
> }
>
> static void
___________________________________________________________________________
Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200008171723.KAA94975>