Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 14 Jul 2010 15:11:46 +0200
From:      Hans Petter Selasky <hselasky@c2i.net>
To:        PseudoCylon <moonlightakkiy@yahoo.ca>
Cc:        Sam Leffler <sam@freebsd.org>, freebsd-current@freebsd.org, freebsd-usb@freebsd.org
Subject:   Re: [panic] Race in IEEE802.11 layer towards device drivers
Message-ID:  <201007141511.46190.hselasky@c2i.net>
next in thread | raw e-mail | index | archive | help 

On Wednesday 14 July 2010 14:31:29 PseudoCylon wrote:
> -if(vap->iv_opmode == IEEE80211_M_HOSTAP){
> -RUN_LOCK(sc);
> +if (vap->iv_opmode == IEEE80211_M_HOSTAP)
>  sc->cmdq_key_set = RUN_CMDQ_GO;
> -RUN_UNLOCK(sc);
> -}
>  

> Why are you removing these locks?

Another question:

	i = RUN_CMDQ_GET(&sc->cmdq_store);
	DPRINTF("cmdq_store=%d\n", i);
	sc->cmdq[i].func = run_update_beacon_cb;
	sc->cmdq[i].arg0 = vap;

Why is this code and similar places not enclosed with mutexes?

--HPS

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007141511.46190.hselasky>