Date: Tue, 28 Nov 2006 12:46:02 +0000 (UTC) From: Ruslan Ermilov <ru@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/sys vmmeter.h src/release/picobsd/tinyware/vm vm.c src/sbin/sysctl sysctl.c src/usr.bin/systat vmstat.c src/usr.bin/vmstat vmstat.c Message-ID: <200611281246.kASCk3uW070996@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
ru 2006-11-28 12:46:02 UTC
FreeBSD src repository
Modified files:
sys/sys vmmeter.h
release/picobsd/tinyware/vm vm.c
sbin/sysctl sysctl.c
usr.bin/systat vmstat.c
usr.bin/vmstat vmstat.c
Log:
- Revert signedness type changes to "struct vmtotal"; by making
them unsigned I made the possible overflows hard to detect,
and it only saved 1 bit which isn't principal, even less now
that the underlying issue with the total of virtual memory has
been fixed. (For the record, it will overflow with >=2T of
VM total, with 32-bit ints used to keep counters in pages.)
- While here, fix printing of other "struct vmtotal" members
such as t_rq, t_dw, t_pw, and t_sw as they are also signed.
Reviewed by: bde
MFC after: 3 days
Revision Changes Path
1.10 +8 -12 src/release/picobsd/tinyware/vm/vm.c
1.80 +11 -15 src/sbin/sysctl/sysctl.c
1.28 +14 -14 src/sys/sys/vmmeter.h
1.83 +19 -86 src/usr.bin/systat/vmstat.c
1.97 +3 -4 src/usr.bin/vmstat/vmstat.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611281246.kASCk3uW070996>