Date: Mon, 16 Sep 2013 22:14:05 +0200 From: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <dumbbell@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r255573 - head/sys/dev/drm2/radeon Message-ID: <5237668D.4060108@FreeBSD.org> In-Reply-To: <201309161228.46123.jhb@freebsd.org> References: <201309141724.r8EHOgj8060898@svn.freebsd.org> <201309161228.46123.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 16.09.2013 18:28, John Baldwin wrote: > Note that the PCI bus layer already does pci_save_state() during suspend > and pci_restore_state() during resume, so it is redundant for a driver to > do so. Yes. I mostly wanted to fix the calls for now because it triggers a panic. They'll probably go away, but I'm working on fixing suspend/resume and I was curious if the card state could change between pci_save_state() in pci.c and the same call later in the driver itself. -- Jean-Sébastien Pédron [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlI3ZpMACgkQa+xGJsFYOlMDOQCfaKZ2F9b4uhJSC+ow947wOU4M E4kAnjnPdftbqCJijB+Gn9Jsm4Xviprx =j76f -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5237668D.4060108>