Date: Thu, 16 Aug 2018 12:48:44 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Ian Lepore <ian@freebsd.org>, Jung-uk Kim <jkim@FreeBSD.org>, Ravi Pokala <rpokala@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Brad Davis <brd@freebsd.org> Subject: Re: svn commit: r337791 - in head: crypto/openssl crypto/openssl/apps crypto/openssl/crypto crypto/openssl/crypto/asn1 crypto/openssl/crypto/bio crypto/openssl/crypto/bn crypto/openssl/crypto/bn/asm cr... Message-ID: <546b1fd2-6b80-a3a1-c39e-28c57d4451bf@FreeBSD.org> In-Reply-To: <8e232b42-e74a-d1c2-561d-f729c8c7c431@FreeBSD.org> References: <201808141748.w7EHm3wI027223@repo.freebsd.org> <C5C1BA80-FB1B-4EDC-A9DB-746093868B07@panasas.com> <de95eb75-7d84-9c04-bf9c-ef3757b33a4d@FreeBSD.org> <20180816175403.ub22a5glkczrmfij@ler-imac.local> <c62adb2f-398f-e3a3-d194-3204aa20ce2a@FreeBSD.org> <20180816182115.mqxkpzgifomjodwl@ler-imac.local> <1a403266-d3f8-1e06-01d6-fb1a7e5f29e5@FreeBSD.org> <20180816184745.bmfgz42ko5kfpyz6@ler-imac.local> <57eef2b1-d126-a8da-c45a-d8cab0373a08@FreeBSD.org> <1534446846.1466.43.camel@freebsd.org> <8e232b42-e74a-d1c2-561d-f729c8c7c431@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ZNV8Re9qz8EFM4F9iW61UBQamQ967sV7r Content-Type: multipart/mixed; boundary="ogMxxLplnEIVgpOXLSHc587H7mRoc6DN2"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Ian Lepore <ian@freebsd.org>, Jung-uk Kim <jkim@FreeBSD.org>, Ravi Pokala <rpokala@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Brad Davis <brd@freebsd.org> Message-ID: <546b1fd2-6b80-a3a1-c39e-28c57d4451bf@FreeBSD.org> Subject: Re: svn commit: r337791 - in head: crypto/openssl crypto/openssl/apps crypto/openssl/crypto crypto/openssl/crypto/asn1 crypto/openssl/crypto/bio crypto/openssl/crypto/bn crypto/openssl/crypto/bn/asm cr... References: <201808141748.w7EHm3wI027223@repo.freebsd.org> <C5C1BA80-FB1B-4EDC-A9DB-746093868B07@panasas.com> <de95eb75-7d84-9c04-bf9c-ef3757b33a4d@FreeBSD.org> <20180816175403.ub22a5glkczrmfij@ler-imac.local> <c62adb2f-398f-e3a3-d194-3204aa20ce2a@FreeBSD.org> <20180816182115.mqxkpzgifomjodwl@ler-imac.local> <1a403266-d3f8-1e06-01d6-fb1a7e5f29e5@FreeBSD.org> <20180816184745.bmfgz42ko5kfpyz6@ler-imac.local> <57eef2b1-d126-a8da-c45a-d8cab0373a08@FreeBSD.org> <1534446846.1466.43.camel@freebsd.org> <8e232b42-e74a-d1c2-561d-f729c8c7c431@FreeBSD.org> In-Reply-To: <8e232b42-e74a-d1c2-561d-f729c8c7c431@FreeBSD.org> --ogMxxLplnEIVgpOXLSHc587H7mRoc6DN2 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 8/16/18 12:31 PM, Bryan Drewery wrote: > On 8/16/18 12:14 PM, Ian Lepore wrote: >> On Thu, 2018-08-16 at 12:10 -0700, Bryan Drewery wrote: >>> On 8/16/18 11:47 AM, Larry Rosenman wrote: >>>> >>>> On Thu, Aug 16, 2018 at 11:34:59AM -0700, Bryan Drewery wrote: >>>>> >>>>> On 8/16/18 11:21 AM, Larry Rosenman wrote: >>>>>> >>>>>> On Thu, Aug 16, 2018 at 02:02:52PM -0400, Jung-uk Kim wrote: >>>>>>> >>>>>>> On 18. 8. 16., Larry Rosenman wrote: >>>>>>>> >>>>>>>> On Thu, Aug 16, 2018 at 01:48:40PM -0400, Jung-uk Kim >>>>>>>> wrote: >>>>>>>>> >>>>>>>>> On 18. 8. 16., Ravi Pokala wrote: >>>>>>>>>> >>>>>>>>>> -----Original Message----- >>>>>>>>>> From: <owner-src-committers@freebsd.org> on behalf of >>>>>>>>>> Jung-uk Kim <jkim@FreeBSD.org> >>>>>>>>>> Date: 2018-08-14, Tuesday at 10:48 >>>>>>>>>> To: <src-committers@freebsd.org>, <svn-src-all@freebsd. >>>>>>>>>> org>, <svn-src-head@freebsd.org> >>>>>>>>>> Subject: svn commit: r337791 - in head: crypto/openssl >>>>>>>>>> crypto/openssl/apps crypto/openssl/crypto >>>>>>>>>> crypto/openssl/crypto/asn1 crypto/openssl/crypto/bio >>>>>>>>>> crypto/openssl/crypto/bn crypto/openssl/crypto/bn/asm >>>>>>>>>> cr... >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Author: jkim >>>>>>>>>>> Date: Tue Aug 14 17:48:02 2018 >>>>>>>>>>> New Revision: 337791 >>>>>>>>>>> URL: https://svnweb.freebsd.org/changeset/base/337791 >>>>>>>>>>> >>>>>>>>>>> Log: >>>>>>>>>>> =C2=A0 Merge OpenSSL 1.0.2p. >>>>>>>>>> Is it just me, or did this change break all the worlds? >>>>>>>>>> >>>>>>>>>> I got errors like this: >>>>>>>>>> >>>>>>>>>> ----------------------------------------------------- >>>>>>>>>> ----------- >>>>>>>>>> /usr/bin/ld: error: undefined symbol: main >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> referenced by crt1.c:74 >>>>>>>>>>>>> (/usr/home/rpokala/freebsd/clean/base/head/lib/cs >>>>>>>>>>>>> u/amd64/crt1.c:74) >>>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0/build/usr/home/rpokala/freebsd/cle >>>>>>>>>>>>> an/base/head/amd64.amd64/tmp/usr/lib/crt1.o:(_sta >>>>>>>>>>>>> rt) >>>>>>>>>> /usr/bin/ld: error: undefined symbol: Fssh_error >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> referenced by moduli.c:257 >>>>>>>>>>>>> (/usr/home/rpokala/freebsd/clean/base/head/crypto >>>>>>>>>>>>> /openssh/moduli.c:257) >>>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0/tmp/moduli- >>>>>>>>>>>>> 6780ab.o:(Fssh_gen_candidates) >>>>>>>>>> ----------------------------------------------------- >>>>>>>>>> ----------- >>>>>>>>>> >>>>>>>>>> At first I thought it was because I was rebuilding >>>>>>>>>> without cleaning, but I nuked the tree and rebuilt from >>>>>>>>>> scratch, and got the same error. >>>>>>>>>> >>>>>>>>>> I didn't bisect it to this change, but it's the only >>>>>>>>>> recent change to crypto... >>>>>>>>> I built worlds many times and I haven't seen such >>>>>>>>> problem.=C2=A0=C2=A0In fact, >>>>>>>>> Jenkins didn't break on amd64 after the commit. >>>>>>>>> >>>>>>>>> https://ci.freebsd.org/job/FreeBSD-head-amd64-build/9888/ >>>>>>>> Do you or jenkins run with meta-mode?=C2=A0=C2=A0That seems to b= e a >>>>>>>> necessary >>>>>>>> condition for the failure. >>>>>>> I don't do meta-mode.=C2=A0=C2=A0I don't know much about Jenkins = build >>>>>>> but I don't >>>>>>> think it does.=C2=A0=C2=A0Is it a requirement now? >>>>>>> >>>>> Jenkins doesn't use META_MODE and it's not a requirement. >>>> Can you (bdrewery@) possibly diagnose why meta-mode is messing this >>>> up >>>> with the moduli file? >>>> >>>>> >>>>> >>> Sure. I'm hitting it as well. >>> >>> >> >> There's a thread about it in -current@ too. >> >> -- Ian >> >=20 >=20 > META_MODE is a distraction here, it fails without it in a clean build. > The current@ thread explains why due to moduli.c being in the .PATH now= =2E >=20 >> ~/git/freebsd/secure/usr.sbin/sshd # make buildconfig -dmM MK_META_MOD= E=3Dno >> Make_ExpandUse: examine buildconfig >> MakeAddChild: need to examine moduli >> MakeAddChild: need to examine sshd_config >> Make_ExpandUse: examine moduli >> MakeAddChild: need to examine moduli.c >> Make_ExpandUse: examine sshd_config >> Make_ExpandUse: examine moduli.c >> Examining moduli.c...modified 7:59:30 Jun 07, 2018...up-to-date. >> Examining moduli...modified 0:00:00 Nov 30, 2017...modified before so= urce /root/git/freebsd/crypto/openssh/moduli.c...out-of-date. >> cc -O2 -pipe -I/root/git/freebsd/crypto/openssh -include ssh_namespa= ce.h -DHAVE_LDNS=3D1 -DUSE_BSM_AUDIT=3D1 -DHAVE_GETAUDIT_ADDR=3D1 -DUSE_B= LACKLIST=3D1 -I/root/git/freebsd/contrib/blacklist/include -include >> krb5_config.h -DLIBWRAP=3D1 -DXAUTH_PATH=3D\"/usr/local/bin/xauth\" -= g -std=3Dgnu99 -fstack-protector-strong -Wno-pointer-sign -Wno-empty-bod= y -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautologic >> al-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-fun= ction -Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-pack= ed-member -Wno-switch -Wno-switch-enum -Wno-knr-promoted-pa >> rameter -Wno-parentheses -fcolor-diagnostics -Qunused-arguments -L/= scratch/obj/root/git/freebsd/amd64.amd64/lib/libblacklist /root/git/free= bsd/crypto/openssh/moduli.c -o /root/git/freebsd/crypto/op >> enssh/moduli >> /usr/bin/ld: error: undefined symbol: main >>>>> referenced by crt1.c:74 (/usr/src/lib/csu/amd64/crt1.c:74) >=20 >=20 >=20 r337928 should fix it. --=20 Regards, Bryan Drewery --ogMxxLplnEIVgpOXLSHc587H7mRoc6DN2-- --ZNV8Re9qz8EFM4F9iW61UBQamQ967sV7r Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAlt11R0ACgkQNddxu25G l8+xrggAuK2hJ6AR4/RcyBEDWJNo6mL3RTXhFeujp67my+OPOC64XSXJIF96HrDu 9ACWHfXuJHsb7duq7dk808VFd+GGOjAkEbqbUYJfOmsJHduW92lcUF4r4X4IDWaX RQgNnKX1xeFEzX1Ik6Olhqm+p+88zH8cJhFDtNeqlRnzCyWAQlo8XpdPYJRGt17J Gb0AbzG5SJOYpqe6bCOWaSwMwYw/pJtIQC9ZrZe5+HdKbDri7iy096lRH1ENSSwK dXyAiJJMIZZS17eyeB1k7EBlrCeRX+q94vztN3RGyBfQ8y4xUgDhz6NZdM/MYrOd 40LsUA6OD64hSVmFVtmw/2m89KSJxQ== =dSFa -----END PGP SIGNATURE----- --ZNV8Re9qz8EFM4F9iW61UBQamQ967sV7r--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?546b1fd2-6b80-a3a1-c39e-28c57d4451bf>