Date: Sun, 19 Feb 2012 19:01:51 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Mikolaj Golub <trociny@freebsd.org> Cc: "Robert N. M. Watson" <rwatson@freebsd.org>, freebsd-arch@freebsd.org Subject: Re: unix domain sockets on nullfs(5) Message-ID: <20120219170151.GS3283@deviant.kiev.zoral.com.ua> In-Reply-To: <86ehtrf8qf.fsf@kopusha.home.net> References: <D1B8F00C-1E0D-4916-BD4B-FBCAE28E6F22@FreeBSD.org> <86fwfnti5t.fsf@kopusha.home.net> <CAOnPXZ_y5G6uEBWmfuH7qYBh%2B4Pw=O91ztCPEFCOTzWdCzx%2BRA@mail.gmail.com> <BBDE763A-F55E-453D-A503-2489C9040EF6@freebsd.org> <20120112215106.GC31224@deviant.kiev.zoral.com.ua> <86hazntwmu.fsf@kopusha.home.net> <20120123031238.GL31224@deviant.kiev.zoral.com.ua> <86zkcfu9ac.fsf@kopusha.home.net> <20120218215003.GM3283@deviant.kiev.zoral.com.ua> <86ehtrf8qf.fsf@kopusha.home.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sun, Feb 19, 2012 at 11:55:20AM +0200, Mikolaj Golub wrote: > > On Sat, 18 Feb 2012 23:50:03 +0200 Konstantin Belousov wrote: > > KB> On Sat, Feb 18, 2012 at 11:22:03PM +0200, Mikolaj Golub wrote: > >> After collecting all suggestions and additional testing I have got this patch > >> set: > >> > >> http://people.freebsd.org/~trociny/unp_prepare_reclaim.1.patch > KB> Including unpcb.h into vfs_subr.c looks too extreme. Put the prototype > KB> into vnode.h, possibly renaming the function to vfs_unp_reclaim. > > Done. > > >> http://people.freebsd.org/~trociny/unp_connect.LOCKSHARED.1.patch > >> http://people.freebsd.org/~trociny/VOP_UNP.3.patch > KB> I has a painting suggestion there, call the vops VOP_UNP_DETACH etc, > KB> otherwise it takes too much reading to understand that it is not undetach. > > Unfortunately, vnode_if.awk does not support underscores in VOP names. It > failed with "Invalid %% construction" due to the restriction: $2 !~ /^[a-z]+$/. > So I reverted back to the old naming. Ok, might be it makes sense to try to add underscore to the set of allowed symbols. > > The updated patches: > > http://people.freebsd.org/~trociny/unp_prepare_reclaim.2.patch > http://people.freebsd.org/~trociny/unp_connect.LOCKSHARED.1.patch > http://people.freebsd.org/~trociny/VOP_UNP.4.patch In the comment above vfs_unp_reclaim(), say "before socket-type vnode reclamation". I have no further comments. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk9BKv4ACgkQC3+MBN1Mb4hcigCeKs+nrQrCGOZhf1o6TFGa8YFK La0AoLWjyUvLlg5fZUYlgrZdayZjHsK1 =C0Nd -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120219170151.GS3283>