Date: Mon, 17 Jul 2023 20:46:50 +0200 From: tuexen@fh-muenster.de To: Warner Losh <imp@bsdimp.com> Cc: John Baldwin <jhb@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d3152ab23e0e - main - tcbpcb: Always define t_osd Message-ID: <AAE783F2-7921-43C5-9004-93FFE5229BF0@fh-muenster.de> In-Reply-To: <CANCZdfp-1zbXXMenHS3rRzC8-8bR-dgOttMPYdGVBBi0Lt25zA@mail.gmail.com> References: <202307171735.36HHZonv063454@gitrepo.freebsd.org> <ba89809b-0af3-8eb6-afd2-68606450f186@FreeBSD.org> <CANCZdfp-1zbXXMenHS3rRzC8-8bR-dgOttMPYdGVBBi0Lt25zA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On 17. Jul 2023, at 19:54, Warner Losh <imp@bsdimp.com> wrote: > > > > On Mon, Jul 17, 2023 at 11:52 AM John Baldwin <jhb@freebsd.org> wrote: > On 7/17/23 10:35 AM, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=d3152ab23e0e7bee5a0f988ecca2a1187ab82057 > > > > commit d3152ab23e0e7bee5a0f988ecca2a1187ab82057 > > Author: Warner Losh <imp@FreeBSD.org> > > AuthorDate: 2023-07-17 17:22:45 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2023-07-17 17:22:45 +0000 > > > > tcbpcb: Always define t_osd > > > > Always define t_osd. congestion control modules access it > > unconditionally. This fixes the build. > > > > However, this is, at best, a temporary band-aide until the > > larger issues are sorted. > > > > Sponsored by: Netflix > > FWIW, I find that #ifdef's based on kernel options in "core" structures like this > shared with modules is a recipe for disaster. > > Agreed 100% Just trying to get to closure on that concept with all the concerned > parties.... Have a look at https://reviews.freebsd.org/D41059 and let us come to an agreement there. Best regards Michael > > Warner [-- Attachment #2 --] 0 *H 010 `He 0 *H 00 %ف0 *H 01 0 UDE1+0)U "T-Systems Enterprise Services GmbH1 0 U T-Systems Trust Center1%0#U T-TeleSec GlobalRoot Class 20 160222133822Z 310222235959Z01 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1-0+U$DFN-Verein Certification Authority 20"0 *H 0 `fAsMg9Z`GNWKVlUvFEc>pԫT#7( ]Ę7 fxJ2)y T_Jx4twMYZ/l< 5e 2mZjKb84YE6Ixjm[k<q;gz6N)=Q\ 4 u9 i%=+ ;U*^3 1Fk Y t0p0U 0 U 2&JJK 0 U #0Y 6 y"kaҸ,˂J0U 003U ,0*0 +!,0 +!, 0g 0LU E0C0A?=;http://pki0336.telesec.de/rl/TeleSec_GlobalRoot_Class_2.crl0+z0x0,+0 http://ocsp0336.telesec.de/ocspr0H+0<http://pki0336.telesec.de/crt/TeleSec_GlobalRoot_Class_2.cer0 *H >eV-;qOں)!F.8y8tv]bL3j2,LG`Utk,ykMP f0"rM>[ϙR9. D~i;u ;"lGG4}=wMOY>GJXoB .M<I&6,"͋xU;D RiТSW{$Jer900c ,=0 *H 01 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1-0+U$DFN-Verein Certification Authority 20 160524113840Z 310222235959Z01 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA0"0 *H 0 ;y G i9٢0r )_KhLk {-n:W Q6pmc.@уLf= di囤rh9QyӮ/]cqK9zBi@p翞 MGH_e*I- ? T/:W~xJA}S_ȳ*0$? MR6$eǖs$hYv~ x<K7S:8Gmd=<ZEJʀ|LL 00U 00U 0)U "0 0 +!, 0 +!,0 U k:S୲2 ;t0 U #02&JJK 0U 00@><:http://cdp1.pca.dfn.de/global-root-g2-ca/pub/crl/cacrl.crl0@><:http://cdp2.pca.dfn.de/global-root-g2-ca/pub/crl/cacrl.crl0+003+0'http://ocsp.pca.dfn.de/OCSP-Server/OCSP0J+0>http://cdp1.pca.dfn.de/global-root-g2-ca/pub/cacert/cacert.crt0J+0>http://cdp2.pca.dfn.de/global-root-g2-ca/pub/cacert/cacert.crt0 *H xENU j>xh5 ?k8w,>̨͠3$b6LxnPn`OR1CFubnfQB1gPI9 ˟ʆHK+f8 W-L_>\)9l{F 8ܰ?q 3Hc%%<z{Wn8︠/[Kl=w 3Sv&%Ao/|~ `]AaI)ب-uJU4"0)0 &BґA7?0 *H 01 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA0 220530132215Z 250529132215Z01 0 UDE1 0U Nordrhein-Westfalen10U Muenster10U FH Muenster1200U )Fachbereich Elektrotechnik und Informatik10 U Tuexen10U* Michael10U Michael Tuexen0"0 *H 0 {R}HI'ϻYĩhx+C 4P"Ty)PRw Vf>1{Bak eĜ~< 6?cym,m d 3 nDzX l}$v#dij1J b鴽/ ;& "n 6 er8vʝ gKVq}c1ｖ<;i8BU ~X,s|tٯߨ{1H\EfvzZ ؆M/t$1"Q$Usמ>ׅ*fߗqVzwz2졈l7]) &f'c >ڒ'veV)뛿=a/zd! $6m~v<;B?<=(ӂzT 9.#{_aJEP= ɽxO5mtZ q9KHAE1Iٵud[ W K!*-w N N0J0>U 7050 +!,0+!, 0+!, 0 U 0 0U 0 U %0++0 U PD:~WEǴ(q0 U #0k:S୲2 ;t0 U 0tuexen@fh-muenster.de0U 00?=;9http://cdp1.pca.dfn.de/dfn-ca-global-g2/pub/crl/cacrl.crl0?=;9http://cdp2.pca.dfn.de/dfn-ca-global-g2/pub/crl/cacrl.crl0+003+0'http://ocsp.pca.dfn.de/OCSP-Server/OCSP0I+0=http://cdp1.pca.dfn.de/dfn-ca-global-g2/pub/cacert/cacert.crt0I+0=http://cdp2.pca.dfn.de/dfn-ca-global-g2/pub/cacert/cacert.crt0 *H ./x ĬNuӌ.- |2 Rz PtR4`]`OɡX, լUDZP}4?U+ς ` v<[ 7*;j .!8Y{ߣGIV8[xᲒ)*MZX1銘~4kr90@Yۜmy~?Q];2+ܩ̹b0IU0YW{; aU k10001 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA &BґA7?0 `He 0 *H 1 *H 0 *H 1 230717184650Z0/ *H 1" ˾OklƤń,0 +71001 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA &BґA7?0 *H 101 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA &BґA7?0 *H CF{~ :WFޣWxZ&JB xsd",qZ-nY7~<$ g Sm B 2 W/ODa~MbZuŝ{08 r(1τl}ˍ(PM匍В!b;3}q^C["~M >p{Vbi]x`R"!HG-}- Ͷ1l!=,lr PFm',bJS9>f͘ EHN µ̔yCcK<hpo ABXAT9XcdE\ w.FJ ^-'U' -r L5 D*gjF4NO'{H܇iyj N(+S a&Kwn yJ)1t az4[]7 2dD .&1%.ƫS92Bm\jY0yM܋-E
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AAE783F2-7921-43C5-9004-93FFE5229BF0>