Date: Sun, 31 Dec 2017 11:54:00 -0500 From: Steve Wills <swills@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, idefix@fechner.net, Torsten Zuehlsdorff <tz@FreeBSD.org> Subject: Re: svn commit: r457671 - head/textproc/rubygem-loofah Message-ID: <c645ba31-20e8-4a6c-2f4f-9b9d0c8780cf@FreeBSD.org> In-Reply-To: <CAMHz58Tpkoth-5uxTKqOgfj2QvH5GCWdZtJsVhjVAeBcCednuA@mail.gmail.com> References: <201712310635.vBV6ZKUq075623@repo.freebsd.org> <CAMHz58Tpkoth-5uxTKqOgfj2QvH5GCWdZtJsVhjVAeBcCednuA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On 12/31/2017 09:01, Sunpoet Po-Chuan Hsieh wrote: > On Sun, Dec 31, 2017 at 2:35 PM, Steve Wills <swills@freebsd.org > <mailto:swills@freebsd.org>> wrote: > > Author: swills > Date: Sun Dec 31 06:35:19 2017 > New Revision: 457671 > URL: https://svnweb.freebsd.org/changeset/ports/457671 > <https://svnweb.freebsd.org/changeset/ports/457671>; > > Log: > textproc/rubygem-loofah: update to 2.1.1 > > > Hi Steve, > > www/gitlab is the only consumer of rubygem-loofah and rubygem-omniauth-saml. > Regarding r457670 and r457671, you may need to patch gitlab because it > requires: > > from Gemfile: > gem 'omniauth-saml', '~> 1.7.0' > gem 'loofah', '~> 2.0.3' > > That's why I did not update them. We should create ports for the versions it needs. We can have those maintained by the GitLab maintainer if that helps avoid the issue, and/or leave a comment in them about why they are there, which will help with removing them if/when they aren't needed any more because GitLab updates to the newer version. First, we should test if GitLab can successfully use the new version and it's just an overly pessimistic version constraint or really needs the old one. I'll leave that to the GitLab port maintainer. I'm happy to help create the needed ports once we confirm we need them. Thanks, Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c645ba31-20e8-4a6c-2f4f-9b9d0c8780cf>