Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Dec 2012 22:21:28 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r244719 - in head/sys/dev/usb: . quirk
Message-ID:  <201212262221.qBQMLSWU053261@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Wed Dec 26 22:21:27 2012
New Revision: 244719
URL: http://svnweb.freebsd.org/changeset/base/244719

Log:
  Add the NO_SYNC_CACHE quirk for all Apple USB MSC devices, as they
  typically do not handle the SYNCHRONIZE_CACHE command - they either
  return an error or the firmware enters a reset loop.
  
  Reviewed by:	hselasky
  Approved by:	rstone (co-mentor)
  MFC after:	2 weeks

Modified:
  head/sys/dev/usb/quirk/usb_quirk.c
  head/sys/dev/usb/usbdevs

Modified: head/sys/dev/usb/quirk/usb_quirk.c
==============================================================================
--- head/sys/dev/usb/quirk/usb_quirk.c	Wed Dec 26 21:47:07 2012	(r244718)
+++ head/sys/dev/usb/quirk/usb_quirk.c	Wed Dec 26 22:21:27 2012	(r244719)
@@ -482,6 +482,7 @@ static struct usb_quirk_entry usb_quirks
 	 * after issuing non-supported commands:
 	 */
 	USB_QUIRK(ALCOR, DUMMY, 0x0000, 0xffff, UQ_MSC_NO_SYNC_CACHE, UQ_MSC_NO_TEST_UNIT_READY, UQ_MATCH_VENDOR_ONLY),
+	USB_QUIRK(APPLE, DUMMY, 0x0000, 0xffff, UQ_MSC_NO_SYNC_CACHE, UQ_MATCH_VENDOR_ONLY),
 	USB_QUIRK(FEIYA, DUMMY, 0x0000, 0xffff, UQ_MSC_NO_SYNC_CACHE, UQ_MATCH_VENDOR_ONLY),
 	USB_QUIRK(REALTEK, DUMMY, 0x0000, 0xffff, UQ_MSC_NO_SYNC_CACHE, UQ_MATCH_VENDOR_ONLY),
 	USB_QUIRK(INITIO, DUMMY, 0x0000, 0xffff, UQ_MSC_NO_SYNC_CACHE, UQ_MATCH_VENDOR_ONLY),

Modified: head/sys/dev/usb/usbdevs
==============================================================================
--- head/sys/dev/usb/usbdevs	Wed Dec 26 21:47:07 2012	(r244718)
+++ head/sys/dev/usb/usbdevs	Wed Dec 26 22:21:27 2012	(r244719)
@@ -1050,6 +1050,7 @@ product AOX USB101		0x0008	Ethernet
 product APC UPS			0x0002	Uninterruptible Power Supply
 
 /* Apple Computer products */
+product APPLE DUMMY		0x0000	Dummy product
 product APPLE IMAC_KBD		0x0201	USB iMac Keyboard
 product APPLE KBD		0x0202	USB Keyboard M2452
 product APPLE EXT_KBD		0x020c	Apple Extended USB Keyboard



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201212262221.qBQMLSWU053261>