Date: Tue, 5 Oct 2010 11:27:24 +0300 From: Mykola Dzham <i@levsha.me> To: kientzle@freebsd.org, freebsd-current@freebsd.org Subject: bin/tar incorrectly parse '[^...]' patterns in --exclude Message-ID: <20101005082723.GA2540@laptop.levsha.me>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Hi!
bsd tar parse only '[!...]' as negate pattern, but gnu tar and bsd tar
on 8-STABLE parse '[^...]' too:
# uname -a
FreeBSD laptop.levsha.me 9.0-CURRENT FreeBSD 9.0-CURRENT #4 r212602M: Wed Sep 15 04:50:20 EEST 2010 root@laptop.levsha.me:/usr/obj/usr/src/sys/LEVSHA amd64
# tar --version
bsdtar 2.8.3 - libarchive 2.7.901a
# tar -tzvf test.tbz
-rw-r--r-- 0 levsha levsha 0 Oct 5 01:27 a
-rw-r--r-- 0 levsha levsha 0 Oct 5 01:27 b
-rw-r--r-- 0 levsha levsha 0 Oct 5 01:27 c
-rw-r--r-- 0 levsha levsha 0 Oct 5 01:27 d
# tar -tzvf test.tbz --exclude '[!a]'
-rw-r--r-- 0 levsha levsha 0 Oct 5 01:27 a
# tar -tzvf test.tbz --exclude '[^a]'
-rw-r--r-- 0 levsha levsha 0 Oct 5 01:27 b
-rw-r--r-- 0 levsha levsha 0 Oct 5 01:27 c
-rw-r--r-- 0 levsha levsha 0 Oct 5 01:27 d
# gtar -tzvf test.tbz --exclude '[^a]'
-rw-r--r-- levsha/levsha 0 2010-10-05 01:27 a
#
# uname -a
FreeBSD levsha.kiev.xxx.com.ua 8.1-STABLE FreeBSD 8.1-STABLE #10 r212252: Mon Sep 6 13:12:07 EEST 2010 root@levsha.kiev.xxx.com.ua:/usr/obj/usr/src/sys/LEVSHA i386
# tar --version
bsdtar 2.7.0 - libarchive 2.7.0
# tar -tzvf test.tbz
-rw-r--r-- 0 levsha levsha 0 5 ΦΟΧ 01:27 a
-rw-r--r-- 0 levsha levsha 0 5 ΦΟΧ 01:27 b
-rw-r--r-- 0 levsha levsha 0 5 ΦΟΧ 01:27 c
-rw-r--r-- 0 levsha levsha 0 5 ΦΟΧ 01:27 d
# tar -tzvf test.tbz --exclude '[!a]'
-rw-r--r-- 0 levsha levsha 0 5 ΦΟΧ 01:27 a
# tar -tzvf test.tbz --exclude '[^a]'
-rw-r--r-- 0 levsha levsha 0 5 ΦΟΧ 01:27 a
#
Fix:
Index: usr.bin/tar/pathmatch.c
===================================================================
--- usr.bin/tar/pathmatch.c (revision 212602)
+++ usr.bin/tar/pathmatch.c (working copy)
@@ -35,7 +35,7 @@
/*
* Check whether a character 'c' is matched by a list specification [...]:
- * * Leading '!' negates the class.
+ * * Leading '!' or '^' negates the class.
* * <char>-<char> is a range of characters
* * \<char> removes any special meaning for <char>
*
@@ -60,7 +60,7 @@
(void)flags; /* UNUSED */
/* If this is a negated class, return success for nomatch. */
- if (*p == '!' && p < end) {
+ if ((*p == '!' || *p == '^') && p < end) {
match = 0;
nomatch = 1;
++p;
--
LEFT-(UANIC|RIPE)
JID: levsha@jabber.net.ua
PGP fingerprint: 1BCD 7C80 2E04 7282 C944 B0E0 7E67 619E 4E72 9280
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)
iQEcBAEBAgAGBQJMquFqAAoJEH5nYZ5OcpKAAogH/2FkLl3MSbRIHVYrVfHllJUr
mLRiSJAUXMezUHS+gZwELYDw0IikXL6RBDdbzruNoR/CvaGSML+qKw1s27PCADQx
/6D5/JDVHd0oSQe/gMQhBJrxWnOnJSfo+o9YoK0Re5+AmZWtOuwv0vQtDqb2z0Qc
VQun9lJ2lsiIF7w+NkX0O6AOYtWDSTl04UoPtj7hQcONvx32NxaqX3Lj2/garrFV
lzAHXbaWJRGqnDt7bd/bpuVaBvqHWU3J8RySqALFkixTVUx3o7uObIeJpej596GV
U2/y+gybKEXQVwwY2QSENOLhnlJnl1P7kIoYHCasH3z2eYmtfk89u2ef/JWUVyQ=
=zRg9
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101005082723.GA2540>