Date: Mon, 25 Feb 2013 09:39:48 +0400 From: Ruslan Makhmatkhanov <cvs-src@yandex.ru> To: araujo@FreeBSD.org Cc: Marcelo Araujo <araujobsdport@gmail.com>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Po-Chien Lin <pclin@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r312904 - head/net-im/imspector Message-ID: <512AF924.40504@yandex.ru> In-Reply-To: <CAOfEmZh3mqERhFPS8eYfgbCsnNtMq5kPiyYQnTHh5=vKnWRv0A@mail.gmail.com> References: <201302250425.r1P4Pc9u020378@svn.freebsd.org> <CAOfEmZh3mqERhFPS8eYfgbCsnNtMq5kPiyYQnTHh5=vKnWRv0A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Marcelo Araujo wrote on 25.02.2013 08:35: > 2013/2/25 Po-Chien Lin <pclin@freebsd.org> > >> Author: pclin >> Date: Mon Feb 25 04:25:37 2013 >> New Revision: 312904 >> URL: http://svnweb.freebsd.org/changeset/ports/312904 >> >> Log: >> - Add IPFW suuport [1] and enable it by default [2] >> - Trim Makefile header [2] >> - Remove invalid entry from MASTER_SITES >> - Patch to fix clang compiling >> - Tune pkg-plist to pet portlint(1) >> >> PR: ports/175765 >> Submitted by: Oleg_Sch <7zsfx@7zsfx.info> [1] >> Approved by: Mikhail Tsatsenko <m.tsatsenko@gmail.com> (maintainer) [2] >> Approved by: swills (mentor) >> >> > Dear Po-Chien, > > For my eyes, it is pretty much strange when we have two lines of "Approved > by" or more then one line of Submitted by or wherever, usually we use only > one line, and something like bellow: > > Approve by: Mikhail Tsatsenko <m.tsatsenko@gmail.com> (maintainer) > swills (mentor) > > An example to submit: > > PR: ports/1111 [1], ports/22222 [2], ports/33333 [3] Will this line be expanded up to three gnats followups (with commit message) for three different pr's? If I recall correctly it was suggested to use exactly this form to make sure everything is right: PR: ports/1111 [1] PR: ports/22222 [2] PR: ports/33333 [3] And I stick this style because of that reason. Can anybody clarify (once again)? -- Regards, Ruslan Tinderboxing kills... the drives.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?512AF924.40504>