Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Sep 1998 12:50:28 -0700 (PDT)
From:      Studded@dal.net
To:        FreeBSD-gnats-submit@FreeBSD.ORG
Subject:   bin/7979: Problems in -Stable login.c
Message-ID:  <199809181950.MAA01993@dt053nb4.san.rr.com>

next in thread | raw e-mail | index | archive | help

>Number:         7979
>Category:       bin
>Synopsis:       Typo and one odd thing in -Stable login.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 18 13:00:00 PDT 1998
>Last-Modified:
>Originator:     Doug
>Organization:
AAAG
>Release:        FreeBSD 2.2.7-STABLE-0918 i386
>Environment:

	-Stable system

>Description:

	There is a typo in login.c,v 1.12.2.12, the most recent -Stable version
(approvp for approvep). Also, a change from -Current re AUTH_NONE (which isn't
defined in any include file which is included in login.c) was not included. 

>How-To-Repeat:

	DNA

>Fix:
	
	Apply the following patch.

diff -u -r1.12.2.12 -r1.38
--- login.c     1998/08/31 03:27:28     1.12.2.12
+++ login.c     1998/08/17 03:25:07     1.38
@@ -409,7 +414,7 @@
                }
 
                if (!rval) {
-                       char * approvp;
+                       char * approvep;
                    
                        /*
                         * If authentication succeeds, run any approval
@@ -427,7 +432,7 @@
                                /*
                                 * See what the authorize program says
                                 */
-                               if (r != AUTH_NONE) {
+                               if (r != 0) {
                                        rval = 0;
 
                                        if (!rootok && (r & AUTH_ROOTOKAY))

>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199809181950.MAA01993>