Date: Mon, 19 Mar 2012 22:29:42 -0400 From: Wesley Shields <wxs@FreeBSD.org> To: Michael Scheidell <scheidell@freebsd.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/opennurbs Makefile pkg-plist Message-ID: <20120320022942.GC27552@atarininja.org> In-Reply-To: <4F67438C.605@freebsd.org> References: <201203191403.q2JE3sM8051201@repoman.freebsd.org> <20120319143041.GB27552@atarininja.org> <4F67438C.605@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 19, 2012 at 10:32:44AM -0400, Michael Scheidell wrote:
>
>
> On 3/19/12 10:30 AM, Wesley Shields wrote:
> > Isn't it better to use ${INSTALL_DATA} here?
> >
> > -- WXS
> open a pr, let maintainer approve it.
As the person who committed this it is your responsibility to see that
issues raised are properly fixed. If you feel like the maintainer should
be brought in for such a simple change that is your decision to make,
but I shouldn't have to open a PR to address this.
> Id also like to see examples wrapper in a .if/endif and pkg-plist
> prefixed with %%PORTEXAMPLES%%%EXAMPLES%% .
Would be nice to have also, but not my point. Using ${INSTALL_DATA} is
the right thing to do because it sets the owner and mode properly.
-- WXS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120320022942.GC27552>