Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Aug 2010 22:58:14 +0200
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        "M. Warner Losh" <imp@bsdimp.com>
Cc:        svn-src-head@FreeBSD.org, marius@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org
Subject:   Re: svn commit: r211722 - head/cddl/lib/libzpool
Message-ID:  <20100830205814.GF1871@garage.freebsd.pl>
In-Reply-To: <20100823.173600.180924398998066421.imp@bsdimp.com>
References:  <201008232204.o7NM4UPA054870@svn.freebsd.org> <20100823.173600.180924398998066421.imp@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--/Zw+/jwnNHcBRYYu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 23, 2010 at 05:36:00PM -0600, M. Warner Losh wrote:
> In message: <201008232204.o7NM4UPA054870@svn.freebsd.org>
>             Marius Strobl <marius@freebsd.org> writes:
> : Author: marius
> : Date: Mon Aug 23 22:04:30 2010
> : New Revision: 211722
> : URL: http://svn.freebsd.org/changeset/base/211722
> :=20
> : Log:
> :   Use real atomic operations for sparc64.
> :  =20
> :   MFC after:	1 week
> :=20
> : Modified:
> :   head/cddl/lib/libzpool/Makefile
> :=20
> : Modified: head/cddl/lib/libzpool/Makefile
> : =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> : --- head/cddl/lib/libzpool/Makefile	Mon Aug 23 21:40:03 2010	(r211721)
> : +++ head/cddl/lib/libzpool/Makefile	Mon Aug 23 22:04:30 2010	(r211722)
> : @@ -11,7 +11,7 @@
> :  # LIST_SRCS
> :  .PATH: ${.CURDIR}/../../../sys/cddl/contrib/opensolaris/uts/common/os
> :  # ATOMIC_SRCS
> : -.if ${MACHINE_ARCH} =3D=3D "i386" || ${MACHINE_ARCH} =3D=3D "amd64" ||=
 ${MACHINE_ARCH} =3D=3D "ia64" || ${MACHINE_ARCH} =3D=3D "powerpc64"
> : +.if ${MACHINE_ARCH} =3D=3D "i386" || ${MACHINE_ARCH} =3D=3D "amd64" ||=
 ${MACHINE_ARCH} =3D=3D "ia64" || ${MACHINE_ARCH} =3D=3D "sparc64" || ${MAC=
HINE_ARCH} =3D=3D "powerpc64"
> :  .PATH: ${.CURDIR}/../../../sys/cddl/contrib/opensolaris/common/atomic/=
${MACHINE_ARCH}
> :  ATOMIC_SRCS=3D	opensolaris_atomic.S
> :  .else
>=20
> I find it disturbing that we have 3 or 4 copies of this code in our
> Makefiles...

Then you will like @183089 :)

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--/Zw+/jwnNHcBRYYu
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iEYEARECAAYFAkx8G2UACgkQForvXbEpPzR/YgCgxV1kqM98hk1vULOaYj7WD6t9
FrMAoKximnj9Mgpxj3EYO4OMWJlAmeIY
=i/NF
-----END PGP SIGNATURE-----

--/Zw+/jwnNHcBRYYu--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100830205814.GF1871>