Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 24 Sep 2010 19:07:14 +0000 (UTC)
From:      Pyun YongHyeon <yongari@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org
Subject:   svn commit: r213118 - stable/7/sys/pci
Message-ID:  <201009241907.o8OJ7EpX035993@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: yongari
Date: Fri Sep 24 19:07:14 2010
New Revision: 213118
URL: http://svn.freebsd.org/changeset/base/213118

Log:
  MFC r211716:
    Move xl_reset() to xl_init_locked(). This will make driver
    initialize controller from a known good state. Previously driver
    used to issue controller reset while TX/RX DMA are in progress.
    I guess resetting controller in active TX/RX DMA cycle is to ensure
    stopping I/Os in xl_shutdown(). I remember some buggy controllers
    didn't respond with stop command if controller is under high
    network load at the time of shutdown so resetting controller was
    the only safe way to stop the I/Os. However, from my experiments,
    controller always responded with stop command under high network
    load so I think it's okay to remove the xl_reset() in
    device_shutdown handler.
    Resetting controller also will clear configured RX filter which
    in turn will make WOL support hard because driver have to reprogram
    RX filter in WOL handler as well as setting station address.

Modified:
  stable/7/sys/pci/if_xl.c
Directory Properties:
  stable/7/sys/   (props changed)
  stable/7/sys/cddl/contrib/opensolaris/   (props changed)
  stable/7/sys/contrib/dev/acpica/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)

Modified: stable/7/sys/pci/if_xl.c
==============================================================================
--- stable/7/sys/pci/if_xl.c	Fri Sep 24 19:04:17 2010	(r213117)
+++ stable/7/sys/pci/if_xl.c	Fri Sep 24 19:07:14 2010	(r213118)
@@ -1666,7 +1666,6 @@ xl_detach(device_t dev)
 	/* These should only be active if attach succeeded */
 	if (device_is_attached(dev)) {
 		XL_LOCK(sc);
-		xl_reset(sc);
 		xl_stop(sc);
 		XL_UNLOCK(sc);
 		taskqueue_drain(taskqueue_swi, &sc->xl_task);
@@ -2274,7 +2273,6 @@ xl_intr(void *arg)
 		}
 
 		if (status & XL_STAT_ADFAIL) {
-			xl_reset(sc);
 			ifp->if_drv_flags &= ~IFF_DRV_RUNNING;
 			xl_init_locked(sc);
 		}
@@ -2343,7 +2341,6 @@ xl_poll_locked(struct ifnet *ifp, enum p
 			}
 
 			if (status & XL_STAT_ADFAIL) {
-				xl_reset(sc);
 				ifp->if_drv_flags &= ~IFF_DRV_RUNNING;
 				xl_init_locked(sc);
 			}
@@ -2778,6 +2775,9 @@ xl_init_locked(struct xl_softc *sc)
 	 */
 	xl_stop(sc);
 
+	/* Reset the chip to a known state. */
+	xl_reset(sc);
+
 	if (sc->xl_miibus == NULL) {
 		CSR_WRITE_2(sc, XL_COMMAND, XL_CMD_RX_RESET);
 		xl_wait(sc);
@@ -3260,7 +3260,6 @@ xl_watchdog(struct xl_softc *sc)
 		device_printf(sc->xl_dev,
 		    "no carrier - transceiver cable problem?\n");
 
-	xl_reset(sc);
 	ifp->if_drv_flags &= ~IFF_DRV_RUNNING;
 	xl_init_locked(sc);
 
@@ -3359,7 +3358,6 @@ xl_shutdown(device_t dev)
 	sc = device_get_softc(dev);
 
 	XL_LOCK(sc);
-	xl_reset(sc);
 	xl_stop(sc);
 	XL_UNLOCK(sc);
 
@@ -3391,7 +3389,6 @@ xl_resume(device_t dev)
 
 	XL_LOCK(sc);
 
-	xl_reset(sc);
 	if (ifp->if_flags & IFF_UP) {
 		ifp->if_drv_flags &= ~IFF_DRV_RUNNING;
 		xl_init_locked(sc);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009241907.o8OJ7EpX035993>