Date: Thu, 10 Jan 2008 07:14:24 +1100 From: Peter Jeremy <peterjeremy@optushome.com.au> To: Sam Leffler <sam@errno.com> Cc: Max Laier <max@love2party.net>, src-committers@freebsd.org, cvs-all@freebsd.org, obrien@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c Message-ID: <20080109201424.GA4969@server.vk2pj.dyndns.org> In-Reply-To: <4785058B.1050507@errno.com> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> <e7db6d980801082231p409d86bp34127fa153b56d7a@mail.gmail.com> <20080109170850.GA27993@dragon.NUXI.org> <4785058B.1050507@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 09, 2008 at 09:34:03AM -0800, Sam Leffler wrote: >I observe that netbsd does these sorts of changes in sweeps over the tree= =20 >and w/ multiple people involved to review each other's work. I'd be more= =20 >confident if I saw commits like this include a "Reviewed by:" line. For this sort of commit, it should also be possible to check that you haven't broken anything by cmp(1)ing the .o files or manually preprocessing and diffing the preprocessed files. --=20 Peter Jeremy Please excuse any delays as the result of my ISP's inability to implement an MTA that is either RFC2821-compliant or matches their claimed behaviour. --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHhSsg/opHv/APuIcRAt4bAKCuBoG4hchde78zphaCpiDUKbmgUgCePNtB kFeL1rs/qkUsZl2GoHRVDm0= =J2v3 -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080109201424.GA4969>