Date: Wed, 5 Apr 2023 17:48:03 +0200 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: e933541b2131 - main - devel/samurai: Fix if LOCALBASE is not /usr/local Message-ID: <CAGwOe2YbYHAfgmYP5b7FEw_rSPvypftBCEVkFOJhxT8kuHxQ=g@mail.gmail.com> In-Reply-To: <ZC0qFG4RJTMQ5sx%2B@FreeBSD.org> References: <202304050543.3355hcZX012345@gitrepo.freebsd.org> <ZC0qFG4RJTMQ5sx%2B@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000a1f7a105f898c8ff
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Wed, Apr 5, 2023 at 9:58=E2=80=AFAM Alexey Dokuchaev <danfe@freebsd.org>=
wrote:
> On Wed, Apr 05, 2023 at 05:43:38AM +0000, Fernando Apestegu??a wrote:
> > commit e933541b2131d644ce243630544bcf210fb4be84
> >
> > devel/samurai: Fix if LOCALBASE is not /usr/local
> >
> > PR: 270590
> > Reported by: eric@camachat.org
> > ...
> > PORTNAME=3D samurai
> > DISTVERSION=3D 1.2-16
> > +PORTREVISION=3D 1
>
> Needless bump for build-time change?
>
> > -@@ -3,7 +3,7 @@
> > - PREFIX=3D/usr/local
> > +@@ -1,10 +1,10 @@
> > + .POSIX:
> > + .PHONY: all install clean
> > +
> > +-PREFIX=3D/usr/local
> > ++PREFIX=3D${LOCALBASE}
>
> This doesn't look right, PREFIX is semantically different from LOCALBASE
> even
> though they typically point to the same path (PREFIX is where your
> generated
> stuff goes, LOCALBASE is where you get precursors). If this program abus=
es
> the PREFIX variable and it is actually meant to be LOCALBASE, it's better
> to
> fix the Makefile or at least accompany such change with due comment.
>
>
Should be correct now.
Thanks!
> ./danfe
>
--000000000000a1f7a105f898c8ff
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, Apr 5, 2023 at 9:58=E2=80=AFA=
M Alexey Dokuchaev <<a href=3D"mailto:danfe@freebsd.org">danfe@freebsd.o=
rg</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex=
">On Wed, Apr 05, 2023 at 05:43:38AM +0000, Fernando Apestegu??a wrote:<br>
> commit e933541b2131d644ce243630544bcf210fb4be84<br>
> <br>
>=C2=A0 =C2=A0devel/samurai: Fix if LOCALBASE is not /usr/local<br>
>=C2=A0 =C2=A0 =C2=A0<br>
>=C2=A0 =C2=A0PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0270590<=
br>
>=C2=A0 =C2=A0Reported by:=C2=A0 =C2=A0 <a href=3D"mailto:eric@camachat.=
org" target=3D"_blank">eric@camachat.org</a><br>
> ...<br>
>=C2=A0 PORTNAME=3D=C2=A0 =C2=A0 samurai<br>
>=C2=A0 DISTVERSION=3D 1.2-16<br>
> +PORTREVISION=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 1<br>
<br>
Needless bump for build-time change?<br>
<br>
> -@@ -3,7 +3,7 @@<br>
> - PREFIX=3D/usr/local<br>
> +@@ -1,10 +1,10 @@<br>
> + .POSIX:<br>
> + .PHONY: all install clean<br>
> + <br>
> +-PREFIX=3D/usr/local<br>
> ++PREFIX=3D${LOCALBASE}<br>
<br>
This doesn't look right, PREFIX is semantically different from LOCALBAS=
E even<br>
though they typically point to the same path (PREFIX is where your generate=
d<br>
stuff goes, LOCALBASE is where you get precursors).=C2=A0 If this program a=
buses<br>
the PREFIX variable and it is actually meant to be LOCALBASE, it's bett=
er to<br>
fix the Makefile or at least accompany such change with due comment.<br>
<br></blockquote><div><br></div><div>Should be correct now.</div><div><br><=
/div><div>Thanks!<br></div><div>=C2=A0</div><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">
./danfe<br>
</blockquote></div></div>
--000000000000a1f7a105f898c8ff--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2YbYHAfgmYP5b7FEw_rSPvypftBCEVkFOJhxT8kuHxQ=g>