Date: Wed, 09 Jun 2004 11:31:00 +0900 From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp> To: Barry Bouwsma <freebsd-misuser@remove-NOSPAM-to-reply.NOSPAM.dyndns.dk> Cc: FreeBSD Firewire Developers <freebsd-firewire@freebsd.org> Subject: Re: orb pointer printf() question Message-ID: <87y8mxcviz.wl@tora.nunu.org> In-Reply-To: <200406080857.i588vo301522@Mail.NOSPAM.DynDNS.dK> References: <200406080857.i588vo301522@Mail.NOSPAM.DynDNS.dK>
next in thread | previous in thread | raw e-mail | index | archive | help
At Tue, 8 Jun 2004 10:57:50 +0200 (CEST),
Barry Bouwsma wrote:
>
> [drop the above ipv6-only address that only sometimes works from the
> recipients and I'll catch up later from the archives, thanks]
>
>
> Moin, moin.
>
> A quick question, concerning the following code:
>
> if ((sdev->flags & ORB_POINTER_ACTIVE) != 0) {
> SBP_DEBUG(0)
> printf("%s: orb pointer active\n", __func__);
> END_DEBUG
> sdev->flags |= ORB_POINTER_NEED;
> return;
> }
>
> This is in the sbp.c code from the time of 4.10, which is what I've
> used on my machine with a hard drive attached via firewire.
>
> It seems to be working just fine, with the only thing being that
> the above printf() makes it to the kernel messages a few times
> each minute during disk activity.
>
> Is this something for me to concern myself over? What does it
> mean?
>
> If it's harmless, would it be better to change the above SBP_DEBUG
> to be DEBUG(1) instead of (0) so as not to print at the default
> level of debugging, or is it better to log it as is?
>
>
> thanks
> barry bouwsma
It's harmless.
I believe that the default level of debugging is 0 and
the DEBUG(0) clauses is not executed.
/\ Hidetoshi Shimokawa
\/ simokawa@sat.t.u-tokyo.ac.jp
PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87y8mxcviz.wl>