Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Dec 2010 17:17:07 -0800
From:      Jason Helfman <jhelfman@e-e.com>
To:        Palle Girgensohn <girgen@FreeBSD.org>
Cc:        Jason Helfman <jhelfman@experts-exchange.com>, pphillips@e-e.com, freebsd-ports@freebsd.org
Subject:   Re: postgresql patch
Message-ID:  <20101217011706.GA89888@eggman.experts-exchange.com>
In-Reply-To: <89E39DA34D9EAD2AE23E0A20@girgBook.local>
References:  <20101115174427.297c2d78@eggman> <89E39DA34D9EAD2AE23E0A20@girgBook.local>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi Palle,

Myself and Phil here at experts-exchange worked on a what we think to be a
great patch that could in theory be considered for the other postgresql
servers.

The initial patch was not good, and I understand why that hasn't been
considered. I put a follow-up patch, but found that did break as you pointed
out. 

Today we put in a patch that fixes all of it, and makes the user, group and
id configurable. Builds cleanly in Tinderbox, as well.

http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/153136

We look forward to your comments on this.

Thanks!
Jason

On Tue, Nov 16, 2010 at 08:38:02AM +0100, Palle Girgensohn thus spake:
>I'll check it out, but I believe a correct patch is not quite as simple, it
>needs some tuning when installing files as well, but I may be wrong.
>
>--On 15 november 2010 17.44.27 -0800 Jason Helfman
><jhelfman@experts-exchange.com> wrote:
>
>> Hi,
>>
>> I was hoping you would be able to consider implementing this PR
>> (ports/113707) in all applicable versions if possible?
>>
>> This patch makes the postgresql_user a tunable variable.
>>
>> As it stands now, we are maintaining this internally due to this issue,
>> and would rather release internal maintainership for such a small issue.
>>
>># diff files/postgresql.in.new files/postgresql.in.orig
>> 36c36
>> < postgresql_user=${postgresql_user:-"pgsql"}
>> ---
>>> postgresql_user=pgsql
>>
>> This patch has been on "over to maintainer" since 2007, and was hoping
>> you would have a moment to look at this.
>>
>> Thanks so much,
>> Jason
>
>
>
>
>

-- 
Jason Helfman
System Administrator
experts-exchange.com
http://www.experts-exchange.com/M_4830110.html



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101217011706.GA89888>