Date: Mon, 10 Mar 2014 10:22:33 -0700 From: Lei Zhang <thestig@google.com> To: "Torne (Richard Coles)" <torne@chromium.org> Cc: chromium@freebsd.org, chromium-packagers@chromium.org Subject: Re: [chromium-packagers] more thoughts on porting Chromium to FreeBSD Message-ID: <CACSHbcSqDzQvkgWGGDLhX1KNg47OQK=jXJvYOrs6QqqVAmg1Ow@mail.gmail.com> In-Reply-To: <CAEV-rjf7t6CY_VWczfGhp25EUQyTjSUd%2BA4pphfE7YbHH2n=mw@mail.gmail.com> References: <531D83D1.2050005@freebsd.org> <CAEV-rjdoJg7%2BUvC8Mtdy4xGHz5BdVAEq%2BNUrponhXNQrboeV=Q@mail.gmail.com> <531DE49E.8000207@freebsd.org> <CAEV-rjf7t6CY_VWczfGhp25EUQyTjSUd%2BA4pphfE7YbHH2n=mw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 10, 2014 at 9:59 AM, Torne (Richard Coles) <torne@chromium.org> wrote: > On 10 March 2014 16:13, Ren=C3=A9 Ladan <rene@freebsd.org> wrote: >> Hm, there does not seem to be a hard rule here. Somehow having dedicated >> _freebsd files looks cleaner but that does impose more work. > > > It might look cleaner but if there are cases where the code in _freebsd > would be basically the same, or literally identical, then this makes > maintaining the codebase much harder. Duplication is bad :) There is no hard rule. Use your best judgement on this. If the FreeBSD implementation is completely different, or if trying to share code with other POSIX implementations lead to #ifdef hell, then it might make sense to break out the code into a _freebsd file. In base/ there is a base/nix directory that's POSIX but not Mac. However, the convention has no spread to other parts of the source code. Also, you may want to have this discussion on chromium-dev with a wider audience, rather than chromium-packagers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACSHbcSqDzQvkgWGGDLhX1KNg47OQK=jXJvYOrs6QqqVAmg1Ow>